Skip to content

Conversation

0PrashantYadav0
Copy link
Member

Resolves #3816

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for stats/base/dists/triangular/mean along with relevant tests, docs, examples and benchmarks.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 17, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 17, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/triangular/mean $\color{green}189/189$
$\color{green}+100.00\%$
$\color{green}11/11$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}189/189$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

Left a bunch of comments that will have to be addressed for this PR to move forward.

@Planeshifter Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 18, 2024
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 18, 2024
@0PrashantYadav0
Copy link
Member Author

@Planeshifter Make all the changes. Please review all the changes.

Signed-off-by: Philipp Burckhardt <[email protected]>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edits, @0PrashantYadav0!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 21, 2024
@stdlib-bot stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Dec 21, 2024
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/triangular/mean`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4006
Closes: https://github.com/stdlib-js/stdlib/issues/3816

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit b884459 into stdlib-js:develop Dec 21, 2024
29 checks passed
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
PR-URL: stdlib-js#4006
Closes: stdlib-js#3816

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/triangular/mean

3 participants