Skip to content

Conversation

Neerajpathak07
Copy link
Member

Resolves #3441 .

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for stats/base/dists/betaprime/mean

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Dec 19, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 19, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/betaprime/mean $\color{green}193/193$
$\color{green}+100.00\%$
$\color{green}8/8$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}193/193$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review December 19, 2024 19:28
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 19, 2024
@Planeshifter
Copy link
Member

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Dec 20, 2024
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Dec 20, 2024
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Neerajpathak07 for your PR!

Please ensure you have EditorConfig working to make sure files are properly formatted; left a bunch of comments, the majority related to that.

@Neerajpathak07
Copy link
Member Author

@Planeshifter My system was facing issues while trying to configure .editorconfig but I am able to use it now.
Thanks for the review I have added the suggested changes!!

@Neerajpathak07
Copy link
Member Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 17, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 17, 2025
@Neerajpathak07
Copy link
Member Author

Neerajpathak07 commented Jan 17, 2025

@Planeshifter
Made all the essential changes and updated the PR's related to stats/base/dists packages

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's land it... thanks, Neeraj!

Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 5, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 5, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/betaprime/mean`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4064
Closes: https://github.com/stdlib-js/stdlib/issues/3441

Co-authored-by: Neeraj Pathak <[email protected]>
Co-authored-by: Neerajpathak07 <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Neeraj Pathak <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 6958670 into stdlib-js:develop Feb 5, 2025
27 checks passed
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Feb 11, 2025
PR-URL: stdlib-js#4064
Closes: stdlib-js#3441

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Neeraj Pathak <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
PR-URL: stdlib-js#4064
Closes: stdlib-js#3441

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Neeraj Pathak <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/betaprime/mean

3 participants