Skip to content

feat: add c implementation of stats/base/dists/weibull/pdf #4199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 29, 2024
Merged

feat: add c implementation of stats/base/dists/weibull/pdf #4199

merged 5 commits into from
Dec 29, 2024

Conversation

Vinit-Pandit
Copy link
Contributor

Resolves #3847.

Description

What is the purpose of this pull request?

This pull request:

  • add c implementation of stats/base/dists/weibull/pdf

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

headlessNode and others added 4 commits December 23, 2024 10:24
@headlessNode @Vinit-Pandit
feat: add eslint/rules/eol-open-bracket-spacing
a766b97 
PR-URL: stdlib-js#4061
Private-ref: https://github.com/stdlib-js/todo/issues/2324
Reviewed-by: Athan Reines <[email protected]>

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: passed
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: failed
---
@Vinit-Pandit
Merge remote-tracking branch 'upstream/develop' into develop
54b6eec 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: failed
---
@Vinit-Pandit
Merge remote-tracking branch 'upstream/develop' into develop
171deed 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: passed
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: failed
---
@Vinit-Pandit
feat: add c implementation of stats/base/dists/weibull/pdf
35abe0b 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 24, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 24, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/weibull/pdf $\color{green}310/310$
$\color{green}+100.00\%$ 		$\color{green}36/36$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}310/310$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Planeshifter
Planeshifter approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is looking good, thank you!

Noticed some wrong descriptions where shape and scale parameters were mixed up in the existing Weibull distribution packages, which I will address separately as unrelated to this PR.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Dec 29, 2024
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 29, 2024
@Planeshifter Planeshifter merged commit 1a68a1f into stdlib-js:develop Dec 29, 2024
26 of 27 checks passed
@Vinit-Pandit Vinit-Pandit deleted the stats/base/dists/weibull/pdf branch December 30, 2024 15:20
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 1, 2025
@Vinit-Pandit @Planeshifter @Neerajpathak07
feat: add C implementation of stats/base/dists/weibull/pdf
e493580 
PR-URL: stdlib-js#4199 
Closes: stdlib-js#3847

---------

Signed-off-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
0PrashantYadav0 pushed a commit to 0PrashantYadav0/stdlib that referenced this pull request Jan 9, 2025
@Vinit-Pandit @Planeshifter @0PrashantYadav0
feat: add C implementation of stats/base/dists/weibull/pdf
7ff1aae 
PR-URL: stdlib-js#4199 
Closes: stdlib-js#3847

---------

Signed-off-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@Vinit-Pandit @Planeshifter @ShabiShett07
feat: add C implementation of stats/base/dists/weibull/pdf
85ba5e8 
PR-URL: stdlib-js#4199 
Closes: stdlib-js#3847

---------

Signed-off-by: Philipp Burckhardt <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/weibull/pdf [RFC]: Add C implementations to Weibull distribution functions (tracking issue)

4 participants

@Vinit-Pandit @stdlib-bot @Planeshifter @headlessNode