Skip to content

Conversation

Neerajpathak07
Copy link
Member

Resolves #3579.

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for stats/base/dists/erlang/variance

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Dec 29, 2024
@Neerajpathak07 Neerajpathak07 changed the title feat add C implementation for stats/base/dists/erlang/variance feat: add C implementation for stats/base/dists/erlang/variance Dec 29, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 29, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/erlang/variance $\color{green}199/199$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}199/199$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review December 29, 2024 14:51
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 29, 2024
@Neerajpathak07 Neerajpathak07 marked this pull request as draft January 16, 2025 16:06
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 16, 2025
@Neerajpathak07
Copy link
Member Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 18, 2025
@stdlib-bot
Copy link
Contributor

@Neerajpathak07, slash command not recognized. Please use /stdlib help to view available commands.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 18, 2025
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review January 18, 2025 07:06
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 18, 2025
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Apr 3, 2025
@Neerajpathak07
Copy link
Member Author

@Planeshifter the following PR's on Erlang distribution are ready for review:- #4291 , #4263 and this one!!

@Planeshifter Planeshifter self-requested a review April 5, 2025 02:37
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few edits, but should be ready to land now. Thanks, @Neerajpathak07!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 5, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 5, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/erlang/variance`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4345
Closes: https://github.com/stdlib-js/stdlib/issues/3579

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Neeraj Pathak <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 70e237f into stdlib-js:develop Apr 5, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/erlang/variance

3 participants