Skip to content

Conversation

Neerajpathak07
Copy link
Member

Resolves #3537.

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for stats/base/dists/degenerate/logcdf

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 30, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 30, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/degenerate/logcdf $\color{green}247/247$
$\color{green}+100.00\%$
$\color{green}19/19$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}247/247$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as draft January 16, 2025 16:08
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 16, 2025
@Neerajpathak07
Copy link
Member Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 18, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 18, 2025
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review January 18, 2025 08:28
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 18, 2025
@Neerajpathak07
Copy link
Member Author

cc: @kgryte @Planeshifter
made all the necessary changes through all my PR's on stats/base/dists packages do give it a review when you get time cheers!!

@Neerajpathak07
Copy link
Member Author

Neerajpathak07 commented Feb 6, 2025

Made the changes suggested in the commit in all the other PR's.
cc: @kgryte @Planeshifter

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small edit, otherwise looking good.

…clude/stdlib/stats/base/dists/degenerate/logcdf.h

Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 8, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 8, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add C implementation for `stats/base/dists/degenerate/logcdf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4387
Closes: https://github.com/stdlib-js/stdlib/issues/3537

Co-authored-by: Neeraj Pathak <[email protected]>
Co-authored-by: Neerajpathak07 <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Neeraj Pathak <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit f9789d4 into stdlib-js:develop Feb 8, 2025
27 checks passed
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Feb 11, 2025
PR-URL: stdlib-js#4387
Closes: stdlib-js#3537

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Neeraj Pathak <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
PR-URL: stdlib-js#4387
Closes: stdlib-js#3537

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Neeraj Pathak <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/degenerate/logcdf

3 participants