Skip to content

feat: add C implementation for stats/base/dists/binomial/mgf #4414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jun 23, 2025
Merged

feat: add C implementation for stats/base/dists/binomial/mgf #4414

merged 16 commits into from
Jun 23, 2025

Conversation

@0PrashantYadav0
Copy link
Member

@0PrashantYadav0 0PrashantYadav0 commented Dec 31, 2024

Resolves #3471

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for @stdlib/stats/base/dists/binomial/mgf along with relevant tests, docs, examples and benchmarks.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

Neerajpathak07 and others added 5 commits December 27, 2024 23:49
@Neerajpathak07 @0PrashantYadav0
refactor: update stats/base/dnanmeanpn native addon from C++ to C
692afcb 
PR-URL: stdlib-js#4110
Reviewed-by: Athan Reines <[email protected]>

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: passed
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: passed
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: passed
---
@0PrashantYadav0
Merge branch 'develop' of https://github.com/0PrashantYadav0/stdlib i…
e010038 
…nto develop

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@0PrashantYadav0
Merge branch 'develop' of https://github.com/0PrashantYadav0/stdlib i…
cc882e9 
…nto develop

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@0PrashantYadav0
Merge branch 'stdlib-js:develop' into develop
e9f48a5
@0PrashantYadav0
feat: add C implementation for binomail mgf
46c6e1f 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 31, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 31, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/binomial/mgf $\color{green}326/326$
$\color{green}+100.00\%$ 		$\color{green}25/25$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}326/326$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@0PrashantYadav0
Copy link
Member Author

0PrashantYadav0 commented Jan 6, 2025

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 6, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 6, 2025
@0PrashantYadav0
chore: updated int to double
b52f917 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: passed
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: passed
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@0PrashantYadav0
Copy link
Member Author

0PrashantYadav0 commented Jan 6, 2025

@Planeshifter @kgryte Do i have to STDLIB_MATH_BASE_NAPI_MODULE_DID_D for this implementation or this is ok ?

@0PrashantYadav0 0PrashantYadav0 mentioned this pull request Jan 6, 2025
Open
1 task
@Planeshifter Planeshifter added the bot: Update Copyright Years Pull request needing the copyright years of its files updated. label Feb 9, 2025
@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: Update Copyright Years Pull request needing the copyright years of its files updated. labels Feb 9, 2025
@Planeshifter Planeshifter removed the bot: In Progress Pull request is currently awaiting automation. label Feb 9, 2025
@0PrashantYadav0
Merge branch 'develop' into binomial/mgf
8fd5f8d 
Signed-off-by: JoyBoy <[email protected]>
@0PrashantYadav0
fix: changes in benchmarks
106bc49 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@Planeshifter
Copy link
Member

Planeshifter commented Feb 18, 2025 •
edited
Loading

@0PrashantYadav0 It would be good to have STDLIB_MATH_BASE_NAPI_MODULE_DID_D. Would you be able to create a separate PR adding that macro? Once merged, should then use it in this PR.

@0PrashantYadav0
Copy link
Member Author

0PrashantYadav0 commented Feb 18, 2025

@Planeshifter I opened a PR for that please review and merge after that i will add the implementation in this. Thank you.

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Jun 23, 2025
@Planeshifter
fix: correct documentation issues in binomial/mgf
3a88859 
- Fix C function comment (CDF → MGF)
- Fix parameter name in C documentation (x → t)
- Add missing semicolon in TypeScript example
@Planeshifter
fix: correct critical parameter type issues in binomial/mgf
74da505 
CRITICAL FIXES:
- Fix C function signature: n parameter from double to int32_t
- Fix C header declaration to match implementation
- Fix NAPI macro from DDD_D to DID_D for correct type binding
- Fix README C API documentation (parameter types and signatures)
- Fix C examples and benchmarks to use int32_t for n parameter
- Add missing stdint.h includes

RATIONALE:
- The number of trials (n) in binomial distribution must be integer
- This matches other stdlib binomial implementations
- Fixes parameter validation and type consistency
- Prevents accepting invalid non-integer trial counts

All C code now correctly uses int32_t for discrete count parameter.
@Planeshifter
test: remove failing test cases for non-integer n values in `binomial…
b0bfb38 
…/mgf`

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: passed
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: failed
---
@Planeshifter
chore: minor clean-up
cf3ba96 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
fix: remove unused dependency
eccdf49 
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
Planeshifter approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ready now.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jun 23, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 23, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jun 23, 2025 •
edited by Planeshifter
Loading

PR Commit Message

feat: add C implementation for `stats/base/dists/binomial/mgf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4414
Closes: https://github.com/stdlib-js/stdlib/issues/3471

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: JoyBoy <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit b74cf16 into stdlib-js:develop Jun 23, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/binomial/mgf

4 participants

@0PrashantYadav0 @stdlib-bot @Planeshifter @Neerajpathak07