Skip to content

Conversation

ShabiShett07
Copy link
Contributor

Resolves #3706

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 3, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 3, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/kumaraswamy/stdev $\color{green}201/201$
$\color{green}+100.00\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}201/201$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@ShabiShett07
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 3, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 3, 2025
@ShabiShett07
Copy link
Contributor Author

/stdlib lint-autofix

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jan 4, 2025
@ShabiShett07 ShabiShett07 changed the title feat: add @stdlib/stats/base/dists/kumaraswamy/stdev feat: add stats/base/dists/kumaraswamy/stdev Jan 6, 2025
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ShabiShett07! Did a first review pass and left some comments.

Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Apr 4, 2025
Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 5, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 5, 2025
Signed-off-by: Shabareesh Shetty <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
Copy link
Contributor Author

@Planeshifter, I have added test fixtures, but the problem we have here is high tolerance, which went up to 10000 times epsilon. Is this acceptable?

Signed-off-by: Shabareesh Shetty <[email protected]>
@Planeshifter
Copy link
Member

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jun 23, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jun 23, 2025
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me.

Added a comment due to the massive tolerance needed here; but I cannot find anything wrong.

@ShabiShett07
Copy link
Contributor Author

Looks all good to me.

Added a comment due to the massive tolerance needed here; but I cannot find anything wrong.

Got it, thanks a lot for reviewing this because the tolerance thing was too concerning for me

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jun 23, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 23, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `stats/base/dists/kumaraswamy/stdev`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4513
Closes: https://github.com/stdlib-js/stdlib/issues/3706

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: ShabiShett07 <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit f344e9d into stdlib-js:develop Jun 23, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/kumaraswamy/stdev

3 participants