feat: add C implementation for `stats/base/dists/lognormal/pdf` #4529

NishchayRajput · 2025-01-04T13:00:59Z

Resolves #3755.

Description

What is the purpose of this pull request?

This pull request:

adds C implementation for @stdlib/stats/base/dists/lognormal/pdf along with relevant tests, benchmarks and examples.

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: Add C implementation for @stdlib/stats/base/dists/lognormal/pdf #3755

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

stdlib-bot · 2025-01-04T13:03:39Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/lognormal/pdf	$\color{green}325/325$ $\color{green}+100.00\%$	$\color{green}23/23$ $\color{green}+100.00\%$	$\color{green}4/4$ $\color{green}+100.00\%$	$\color{green}325/325$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

AadishJ · 2025-01-04T17:32:14Z

You need to add 3 lines in the package.json

NishchayRajput · 2025-01-04T17:57:14Z

You need to add 3 lines in the package.json

done

lib/node_modules/@stdlib/stats/base/dists/lognormal/pdf/README.md

lib/node_modules/@stdlib/stats/base/dists/lognormal/pdf/benchmark/benchmark.native.js

lib/node_modules/@stdlib/stats/base/dists/lognormal/pdf/benchmark/c/Makefile

lib/node_modules/@stdlib/stats/base/dists/lognormal/pdf/src/addon.c

lib/node_modules/@stdlib/stats/base/dists/lognormal/pdf/src/main.c

lib/node_modules/@stdlib/stats/base/dists/lognormal/pdf/test/test.native.js

lib/node_modules/@stdlib/stats/base/dists/lognormal/pdf/examples/c/example.c

lib/node_modules/@stdlib/stats/base/dists/lognormal/pdf/lib/native.js

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

NishchayRajput · 2025-02-28T11:48:51Z

@Planeshifter Please review my PR. If there is some issue then I can fix in other PRs as well.

lib/node_modules/@stdlib/stats/base/dists/lognormal/pdf/benchmark/benchmark.js

...dules/@stdlib/stats/base/dists/lognormal/pdf/include/stdlib/stats/base/dists/lognormal/pdf.h

lib/node_modules/@stdlib/stats/base/dists/lognormal/pdf/src/main.c

… implementation for `stats/base/dists/lognormal/pdf` --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

…tion ranges --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: passed - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

lib/node_modules/@stdlib/stats/base/dists/lognormal/pdf/src/addon.c

Signed-off-by: Philipp Burckhardt <[email protected]>

lib/node_modules/@stdlib/stats/base/dists/lognormal/pdf/lib/native.js

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter

Should be ready to land!

Signed-off-by: Philipp Burckhardt <[email protected]>

stdlib-bot · 2025-06-22T17:43:42Z

PR Commit Message

feat: add C implementation for `stats/base/dists/lognormal/pdf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4529
Closes: https://github.com/stdlib-js/stdlib/issues/3755

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

Signed-off-by: Philipp Burckhardt <[email protected]>

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 4, 2025

NishchayRajput changed the title ~~feat: add C implementation for @stdlib/stats/base/dists/lognormal/pdf~~ feat: add C implementation for stats/base/dists/lognormal/pdf Jan 4, 2025

NishchayRajput changed the title ~~feat: add C implementation for stats/base/dists/lognormal/pdf~~ feat: add C implementation for stats/base/dists/lognormal/pdf Jan 4, 2025

fix: updated package.json

b433ef0

NishchayRajput commented Jan 10, 2025

View reviewed changes

NishchayRajput and others added 2 commits January 10, 2025 16:34

stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Feb 28, 2025

NishchayRajput commented Mar 6, 2025

View reviewed changes

Planeshifter added 5 commits June 22, 2025 10:19

Planeshifter reviewed Jun 22, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dists/lognormal/pdf/src/addon.c Outdated Show resolved Hide resolved

style: fix indentation

7f27f99

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter reviewed Jun 22, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dists/lognormal/pdf/lib/native.js Outdated Show resolved Hide resolved

Planeshifter added 2 commits June 22, 2025 12:39

docs: update description

ed29b7e

Signed-off-by: Philipp Burckhardt <[email protected]>

docs: fix section tags

11cb94d

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter previously approved these changes Jun 22, 2025

View reviewed changes

chore: remove cppcheck directive

d1425ac

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter dismissed their stale review via d1425ac June 22, 2025 17:42

Merge branch 'develop' into nishchay-base-lognormal-pdf

5c00bdb

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter previously approved these changes Jun 22, 2025

View reviewed changes

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jun 22, 2025

stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 22, 2025

style: remove extra space

4373779

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter dismissed their stale review via 4373779 June 22, 2025 17:53

Planeshifter approved these changes Jun 22, 2025

View reviewed changes

Planeshifter merged commit 75a786a into stdlib-js:develop Jun 22, 2025
11 checks passed

Uh oh!

feat: add C implementation for stats/base/dists/lognormal/pdf #4529

feat: add C implementation for stats/base/dists/lognormal/pdf #4529

Uh oh!

Conversation

NishchayRajput commented Jan 4, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Jan 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

AadishJ commented Jan 4, 2025

Uh oh!

NishchayRajput commented Jan 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NishchayRajput commented Feb 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Jun 22, 2025 • edited by Planeshifter Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Commit Message

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: add C implementation for `stats/base/dists/lognormal/pdf` #4529

feat: add C implementation for `stats/base/dists/lognormal/pdf` #4529

stdlib-bot commented Jan 4, 2025 •

edited

Loading

stdlib-bot commented Jun 22, 2025 •

edited by Planeshifter

Loading