feat: add C implementation of stats/base/dists/weibull/skewness

[yuvimittal]

Resolves #3849

Description

What is the purpose of this pull request?

This pull request:

• Add C implementation for @stdlib/stats/base/dists/weibull/skewness

Related Issues

Does this pull request have any related issues?

This pull request:

• resolves [RFC]: Add C implementation for @stdlib/stats/base/dists/weibull/skewness #3849

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[DhruvArvindSingh]

In the build object of manifest.json file put all the external dependencies of addon.c , main.c and include folder

[Neerajpathak07]

Suggested change

	"@stdlib/math/base/assert/is-positive-integer",
	"@stdlib/math/base/assert/is-finite",
	"@stdlib/math/base/assert/is-nan",
	"@stdlib/math/base/special/exp",
	"@stdlib/constants/float64/ln-two",
	"@stdlib/math/base/special/ln",
	"@stdlib/math/base/assert/is-integer",
	"@stdlib/math/base/special/gamma"
	"@stdlib/math/base/assert/is-nan",
	"@stdlib/math/base/special/pow",
	"@stdlib/math/base/special/sqrt",
	"@stdlib/math/base/special/gamma"

since most of the header files are not used in the build there is no need to add them here and below for benchmark and examples

[Neerajpathak07]

not sure if this code block is necessary

[Neerajpathak07]

Didn't understand why you are setting values for x but inside function skewness you are passing the parameters k and lambda

[Neerajpathak07]

You have to use uniform function to generate the parameters for added clarity as you did in benchmark.c

Suggested change

	k[ i ] = ( randu() * 10.0 ) + 1.0; // shape parameter > 0
	lambda[ i ] = ( randu() * 10.0 ) + 1.0; // scale parameter > 0
	k[ i ] = uniform( 1.0, 10.0 ); // shape parameter > 0
	lambda[ i ] = uniform( 1.0, 10.0 ); // scale parameter > 0

[Neerajpathak07]

Suggested change

	k = random_uniform( 1.0, 10.0 );
	lambda = random_uniform( 1.0, 10.0 );
	y = stdlib_base_dists_weibull_skewness( k, lambda );
	k = random_uniform( STDLIB_CONSTANT_FLOAT64_EPS, 10.0 );
	lambda = random_uniform( STDLIB_CONSTANT_FLOAT64_EPS, 10.0 );
	y = stdlib_base_dists_weibull_skewness( k, lambda );

[Neerajpathak07]

Suggested change

	y = skewness( k[ i % len ], lambda[ i % len ] );
	y = skewness( k[ i % 100 ], lambda[ i % 100 ] );

[Neerajpathak07]

@yuvi-mittal The reason majority of your test cases are failing is because the test.native.js file is incorrect. You don't have to change the code explicitly use the code from test.js and add opts parameter to create its native version also remember to remove the var skewness and wrap it with tryRequire and resolve functions

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/weibull/skewness	$\color{green}209/209$ $\color{green}+100.00\%$	$\color{green}10/10$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}209/209$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

[yuvimittal]

@kgryte , this PR looks ready to merge to me .

[Planeshifter]

This was resolved in #4053, so closing this PR. Thanks for your efforts!