Skip to content

Conversation

ShabiShett07
Copy link
Contributor

Resolves #3621

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 18, 2025
@ShabiShett07
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 18, 2025
@ShabiShett07
Copy link
Contributor Author

/stdlib lint-autofix

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 18, 2025
@Planeshifter Planeshifter changed the title feat: add C implementation /stats/base/dists/gamma/logpdf feat: add C implementation stats/base/dists/gamma/logpdf Jan 18, 2025
Signed-off-by: Shabareesh Shetty <[email protected]>
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 21, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/gamma/logpdf $\color{red}494/546$
$\color{green}+90.48\%$
$\color{red}40/49$
$\color{green}+81.63\%$
$\color{green}6/6$
$\color{green}+100.00\%$
$\color{red}494/546$
$\color{green}+90.48\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter self-requested a review April 2, 2025 00:22
Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Apr 3, 2025
ShabiShett07 and others added 2 commits April 3, 2025 09:30
Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
Copy link
Contributor Author

@Planeshifter, I have resolved all the conversations.

ShabiShett07 and others added 4 commits April 4, 2025 07:13
Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
Copy link
Contributor Author

@Planeshifter, sorry for having too much corrections, I have resolved all the above conversations.

Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
Copy link
Contributor Author

@Planeshifter, I have included your suggestion and I think it is ready now

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ShabiShett07!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 19, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Apr 19, 2025

PR Commit Message

feat: add C implementation `stats/base/dists/gamma/logpdf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4800
Closes: https://github.com/stdlib-js/stdlib/issues/3621

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 19, 2025
@Planeshifter Planeshifter merged commit 5c47b95 into stdlib-js:develop Apr 19, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/gamma/logpdf

3 participants