Skip to content

Conversation

ShabiShett07
Copy link
Contributor

@ShabiShett07 ShabiShett07 commented Jan 26, 2025

Progresses #649

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@ShabiShett07 ShabiShett07 marked this pull request as draft February 16, 2025 08:36
@ShabiShett07 ShabiShett07 marked this pull request as ready for review February 16, 2025 08:36
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Feb 16, 2025
Signed-off-by: Shabareesh Shetty <[email protected]>
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/dirac-deltaf $\color{green}160/160$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}160/160$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter added the Potential Duplicate There might be another pull request resolving the same issue. label Mar 15, 2025
@Planeshifter
Copy link
Member

⚠️ Tracking Issue Closure Warning ⚠️

I noticed your PR description contains closing keywords ("Resolves", "Closes", or "Fixes") referencing a "Tracking Issue".

Why this matters:
Tracking issues should typically remain open until all related sub-issues are completed. GitHub automatically closes issues with such closing keywords when the PR is merged.

Required action:
Use "Progresses:" or "Ref:" instead to reference the tracking issue without automatically closing it.

Thank you for your contribution to the project!

@kgryte kgryte removed the Potential Duplicate There might be another pull request resolving the same issue. label Mar 17, 2025
@kgryte
Copy link
Member

kgryte commented Mar 17, 2025

Thanks for opening this PR, @ShabiShett07. However, it looks like dirac-deltaf was already added in ff48331. As such, I'll go ahead and close this.

@kgryte kgryte closed this Mar 17, 2025
@kgryte kgryte added Duplicate This issue or pull request already exists. and removed Needs Review A pull request which needs code review. labels Mar 17, 2025
@ShabiShett07 ShabiShett07 deleted the feature/dirac-deltaf branch March 17, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Duplicate This issue or pull request already exists. Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants