bench: refactor random number generation in stats/base/dists/normal

[pranav-1720]

Resolves #4981.

Description

What is the purpose of this pull request?

This pull request:

• Refactors random number generation in JS benchmarks for stats/base/dists/normal.
• Replaces randu() with uniform() for cleaner and more consistent code.
• Moves the random number generation outside the benchmarking loops.

Related Issues

Does this pull request have any related issues?

This pull request:

• resolves #4981.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/normal/cdf	$\color{green}226/226$ $\color{green}+100.00\%$	$\color{green}23/23$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}226/226$ $\color{green}+100.00\%$
stats/base/dists/normal/ctor	$\color{green}487/487$ $\color{green}+100.00\%$	$\color{green}36/36$ $\color{green}+100.00\%$	$\color{green}19/19$ $\color{green}+100.00\%$	$\color{green}487/487$ $\color{green}+100.00\%$
stats/base/dists/normal/entropy	$\color{green}178/178$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}178/178$ $\color{green}+100.00\%$
stats/base/dists/normal/kurtosis	$\color{green}112/112$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}112/112$ $\color{green}+100.00\%$
stats/base/dists/normal/logcdf	$\color{green}248/248$ $\color{green}+100.00\%$	$\color{green}25/25$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}248/248$ $\color{green}+100.00\%$
stats/base/dists/normal/logpdf	$\color{green}235/235$ $\color{green}+100.00\%$	$\color{green}21/21$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}235/235$ $\color{green}+100.00\%$
stats/base/dists/normal/mean	$\color{green}112/112$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}112/112$ $\color{green}+100.00\%$
stats/base/dists/normal/median	$\color{green}112/112$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}112/112$ $\color{green}+100.00\%$
stats/base/dists/normal/mgf	$\color{green}221/221$ $\color{green}+100.00\%$	$\color{green}17/17$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}221/221$ $\color{green}+100.00\%$
stats/base/dists/normal/mode	$\color{green}112/112$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}112/112$ $\color{green}+100.00\%$
stats/base/dists/normal/pdf	$\color{green}239/239$ $\color{green}+100.00\%$	$\color{green}23/23$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}239/239$ $\color{green}+100.00\%$
stats/base/dists/normal/quantile	$\color{green}229/229$ $\color{green}+100.00\%$	$\color{green}25/25$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}229/229$ $\color{green}+100.00\%$
stats/base/dists/normal/skewness	$\color{green}112/112$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}112/112$ $\color{green}+100.00\%$
stats/base/dists/normal/stdev	$\color{green}175/175$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}175/175$ $\color{green}+100.00\%$
stats/base/dists/normal/variance	$\color{green}112/112$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}112/112$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

[anandkaranubc]

Suggested change

	}
	b.toc();
	}
	b.toc();

[anandkaranubc]

This change is still needed.

[anandkaranubc]

Suggested change

	}
	b.toc();
	}
	b.toc();

Same comment as above, and applies throughout the PR

[anandkaranubc]

This still needs to be addressed.

[anandkaranubc]

Suggested change

	}
	b.tic();
	}
	b.tic();

[anandkaranubc]

Suggested change

	y = mode( mu[ i % 100 ], sigma[ i % 100 ] );
	y = mode( mu[ i % len ], sigma[ i % len ] );

[anandkaranubc]

Same comment.

[anandkaranubc]

Suggested change

	y = mypdf( x[ i % 100 ] );
	y = mypdf( x[ i % len ] );

Applies throughout the PR.

[anandkaranubc]

Great work, @pranav-1720! Just a few minor changes needed; otherwise, everything looks good!

And also change in title:

bench: refactor random number generation in stats/base/dists/normal

[pranav-1720]

@anandkaranubc hey have made the changes you suggested

[anandkaranubc]

Suggested change

	}
	b.tic();
	for ( i = 0; i < b.iterations; i++ ) {
	}
	b.tic();
	for ( i = 0; i < b.iterations; i++ ) {

[anandkaranubc]

This change is still pending

[anandkaranubc]

This change is still needed.

[anandkaranubc]

This still needs to be addressed.

[pranav-1720]

@anandkaranubc added the whitespace changes as well. Also is there an automated way to check these whitespace linting isues, the current linting config does not seem to catch them or perhaps i am missing something in my local setup. I get errors for trailing whitespace and some other issues but not the ones you highlighted for this PR

[anandkaranubc]

is there an automated way to check these whitespace linting isues

I don’t think the linter catches all the whitespace linting issues. It does catch some (there might be a reason why it is configured this way). Maybe you can look into improving it, propose an idea in the OH tomorrow, or raise an issue?

[anandkaranubc]

Still some changes to be made. Rest, the PR looks good. Thanks for making those changes!

[anandkaranubc]

Suggested change

	}
	b.tic();
	}
	b.tic();

[anandkaranubc]

Suggested change

	x[ i ] = uniform( EPS + 1.0, 100.0 );
	x[ i ] = uniform( 1.0 + EPS, 100.0 );

Not something that makes a difference, but good for consistency.

[anandkaranubc]

Suggested change

	}
	b.tic();
	}
	b.tic();

This applies throughout the PR

[anandkaranubc]

This change is still pending

[anandkaranubc]

Suggested change

	var uniform = require( '@stdlib/random/base/uniform' );
	var uniform = require( '@stdlib/random/base/uniform' );

[pranav-1720]

fixed, how did you even find that. I dont even know how the space was replaced by tab

[anandkaranubc]

Same comment

[pranav-1720]

@anandkaranubc made the changes, hopefully everything should be in order now. Cheers!

[Planeshifter]

We have moved to using var uniform = require( '@stdlib/random/array/uniform' ); instead of var uniform = require( '@stdlib/random/base/uniform' ); to directly draw arrays filled with numbers from the desired distribution. Since this PR follows our older convention and now has merge conflicts, I am going to close it. Thanks for your contribution either way, it is appreciated!