bench: refactor random number generation in JS benchmarks for stats/base/dists/uniform

[G4URAV001]

…ts/uniform

#4991

Resolves #4991 .

Description

What is the purpose of this pull request?

This pull request improves random number generation in JS benchmarks for stats/base/dists/uniform. Specifically:

• Moves random number generation out of benchmarking loops to prevent interference with benchmark results.
• Uses @stdlib/random/base/uniform and @stdlib/random/base/discrete-uniform instead of randu expressions.
• Ensures generated random values maintain the same range as existing values for consistency.

Related Issues

This pull request:

• Resolves [RFC]: Refactor random number generation in JS benchmarks for stats/base/dists/uniform #4991
• References bench: refactor random number generation in stats/base/dists/beta #4837 and bench: refactor random number generation in stats/base/dists/hypergeometric #4955 as examples of similar improvements.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

✅ Read, understood, and followed the contributing guidelines.
✅ Build Native Add-on.
✅ Run JavaScript Benchmarks.
✅ Run JavaScript Native Benchmarks.

---

@stdlib-js/reviewers

[stdlib-bot]

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/uniform/cdf	$\color{green}225/225$ $\color{green}+100.00\%$	$\color{green}25/25$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}225/225$ $\color{green}+100.00\%$
stats/base/dists/uniform/ctor	$\color{green}479/479$ $\color{green}+100.00\%$	$\color{green}43/43$ $\color{green}+100.00\%$	$\color{green}18/18$ $\color{green}+100.00\%$	$\color{green}479/479$ $\color{green}+100.00\%$
stats/base/dists/uniform/entropy	$\color{green}184/184$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}184/184$ $\color{green}+100.00\%$
stats/base/dists/uniform/kurtosis	$\color{green}186/186$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}186/186$ $\color{green}+100.00\%$
stats/base/dists/uniform/logcdf	$\color{green}229/229$ $\color{green}+100.00\%$	$\color{green}25/25$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}229/229$ $\color{green}+100.00\%$
stats/base/dists/uniform/logpdf	$\color{green}219/219$ $\color{green}+100.00\%$	$\color{green}23/23$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}219/219$ $\color{green}+100.00\%$
stats/base/dists/uniform/mean	$\color{green}175/175$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}175/175$ $\color{green}+100.00\%$
stats/base/dists/uniform/median	$\color{green}175/175$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}175/175$ $\color{green}+100.00\%$
stats/base/dists/uniform/mgf	$\color{green}235/235$ $\color{green}+100.00\%$	$\color{green}21/21$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}235/235$ $\color{green}+100.00\%$
stats/base/dists/uniform/pdf	$\color{green}287/287$ $\color{green}+100.00\%$	$\color{green}25/25$ $\color{green}+100.00\%$	$\color{green}4/4$ $\color{green}+100.00\%$	$\color{green}287/287$ $\color{green}+100.00\%$
stats/base/dists/uniform/quantile	$\color{green}215/215$ $\color{green}+100.00\%$	$\color{green}22/22$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}215/215$ $\color{green}+100.00\%$
stats/base/dists/uniform/skewness	$\color{green}119/119$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}119/119$ $\color{green}+100.00\%$
stats/base/dists/uniform/stdev	$\color{green}122/122$ $\color{green}+100.00\%$	$\color{green}5/5$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}122/122$ $\color{green}+100.00\%$
stats/base/dists/uniform/variance	$\color{green}182/182$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}182/182$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

[anandkaranubc]

Thanks @G4URAV001 for working on this. Left a few comments for you to review. Good luck!

[G4URAV001]

Thanks @G4URAV001 for working on this. Left a few comments for you to review. Good luck!

Thanks @anandkaranubc for the comments. Did all the correction and ran the following tests locally in a dev container -

[x] Build Native Add-on.
[x] Run JavaScript Benchmarks.
[x] Run JavaScript Native Benchmarks.

Still if anything is missed I can do the changes

Sorry for the silly things I missed earlier, I should have been more observant.

Looking forward for more contributions

[Planeshifter]

/stdlib lint-autofix

[Planeshifter]

/stdlib lint-autofix

[Planeshifter]

Thanks for your first PR, which I will go ahead and merge shortly.

Going forward, please make sure you have your local development environment setup correctly, including EditorConfig and ESLint. The PR had a bunch of lint errors that would have been caught by our GIt hooks if properly initialized.

[stdlib-bot]

PR Commit Message

bench: refactor random number generation in JS benchmarks for `stats/base/dists/uniform`

PR-URL: https://github.com/stdlib-js/stdlib/pull/5176
Closes: https://github.com/stdlib-js/stdlib/issues/4991
Ref: https://github.com/stdlib-js/stdlib/issues/4837
Ref: https://github.com/stdlib-js/stdlib/issues/4955

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Karan Anand <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.