Skip to content

feat: add C implementation of stats/base/dists/poisson/logpmf #5194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 14, 2025
Merged

feat: add C implementation of stats/base/dists/poisson/logpmf #5194

merged 6 commits into from
May 14, 2025

Conversation

saurabhraghuvanshii
Copy link
Contributor

Resolves #3788.

Description

What is the purpose of this pull request?

This pull request:

  • Add C implementation for @stdlib/stats/base/dists/poisson/logpmf

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@saurabhraghuvanshii
feat: add c implementation of stats/base/dists/poisson/logpmf
4cdb998 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Feb 11, 2025
@saurabhraghuvanshii saurabhraghuvanshii mentioned this pull request Feb 11, 2025
Closed
1 task
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 11, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/poisson/logpmf $\color{green}292/292$
$\color{green}+100.00\%$ 		$\color{green}29/29$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}292/292$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@saurabhraghuvanshii
chore: remove unwanted chnage in benchmark.js
ac01e56 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@saurabhraghuvanshii
Copy link
Contributor Author

@kgryte @Planeshifter , I think this is ready to merge. take a review

@saurabhraghuvanshii
Copy link
Contributor Author

saurabhraghuvanshii commented Mar 2, 2025 •
edited
Loading

\ stdlib-help

@saurabhraghuvanshii
Copy link
Contributor Author

@kgryte sir look at this , it is completed

@saurabhraghuvanshii
Copy link
Contributor Author

@Planeshifter @kgryte sir is this pr valid or not is not I will close it, outed I think

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label May 14, 2025
@Planeshifter
style: fix indentation
b10ed74 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter
chore: fix printout
ea254b8 
Signed-off-by: Philipp Burckhardt <[email protected]>
@Planeshifter Planeshifter changed the title feat: add c implementation of stats/base/dists/poisson/logpmf feat: add C implementation of stats/base/dists/poisson/logpmf May 14, 2025
@Planeshifter
chore: fix printout
839f97a 
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
Planeshifter approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saurabhraghuvanshii
Sorry for not getting to this earlier; I just reviewed and made a few edits. Should be ready to land. Thanks for your contributions!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label May 14, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label May 14, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented May 14, 2025 •
edited by Planeshifter
Loading

PR Commit Message

feat: add C implementation of `stats/base/dists/poisson/logpmf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/5194
Closes: https://github.com/stdlib-js/stdlib/issues/3788

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit c38ee71 into stdlib-js:develop May 14, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/poisson/logpmf

3 participants

@saurabhraghuvanshii @stdlib-bot @Planeshifter