Skip to content

Conversation

rishavtarway
Copy link
Contributor

Resolves #5305 .

Description

What is the purpose of this pull request?

This pull request: address the commit comments of (commit e05da28)

  • Updated the Return Required value from 3 to 3.0
  • Closed the unclosed code block with missing triple backticks

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

Hi, reviewers! Could you please check if I have followed the contributing guidelines properly? If there are any mistakes or areas for improvement in my code or approach, I would appreciate your feedback. I'm open to suggestions for making it better!

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Feb 19, 2025
@rishavtarway
Copy link
Contributor Author

@kgryte sir i have addressed all the commit comments from issue #5305 can you review it once

@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/binomial/stdev $\color{green}177/177$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}177/177$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@rishavtarway rishavtarway changed the title Chore : Address Commit Comments Style : closed the unclosed code block Feb 19, 2025
@Neerajpathak07
Copy link
Member

Neerajpathak07 commented Feb 19, 2025

Hey @rishavtarway,
Seems that you have a lint PR tittle CI error.
Could you try changing the PR tittle to:-
docs: update C examples in markdown for stdlib/base/dists/binomial/stdev

@rishavtarway rishavtarway changed the title Style : closed the unclosed code block docs: update C examples in markdown for stdlib/base/dists/binomial/stdev Feb 19, 2025
@rishavtarway
Copy link
Contributor Author

@kgryte @anandkaranubc can you review this PR once ?

@anandkaranubc
Copy link
Contributor

anandkaranubc commented Feb 21, 2025

@kgryte @anandkaranubc can you review this PR once ?

The PR looks good! Thanks for working on this.

Can you also update the title to:

docs: update examples for stats/base/dists/binomial/stdev

Note that there are backticks around stats/base/dists/binomial/stdev

@anandkaranubc anandkaranubc added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 21, 2025
@rishavtarway rishavtarway changed the title docs: update C examples in markdown for stdlib/base/dists/binomial/stdev docs: update examples for stdlib/base/dists/binomial/stdev Feb 21, 2025
@rishavtarway
Copy link
Contributor Author

rishavtarway commented Feb 21, 2025

@anandkaranubc I have updated the title as you have suggested can you review

@anandkaranubc
Copy link
Contributor

@anandkaranubc I have updated the title as you have suggested can you review and merge this PR now

Sorry I meant:

docs: update examples for stats/base/dists/binomial/stdev

After this change, you can wait for a maintainer to merge this PR.

@rishavtarway
Copy link
Contributor Author

@anandkaranubc I have updated the title as you have suggested can you review and merge this PR now

Sorry I meant:

docs: update examples for stats/base/dists/binomial/stdev

After this change, you can wait for a maintainer to merge this PR.

yeah sure

@Neerajpathak07
Copy link
Member

Neerajpathak07 commented Feb 21, 2025

Ahh I see what's happening here upon changing the tittle the CI doesn't instantly get reflected you'll have to either close and reopen this PR or best way draft it and again open it.
Since the PR aims to update example C examples in the markdown file I personally think it's better to name the tittle accordingly.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 22, 2025
@stdlib-bot stdlib-bot removed the Needs Changes Pull request which needs changes before being merged. label Feb 22, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 22, 2025

PR Commit Message

docs: update examples for `stdlib/base/dists/binomial/stdev`

PR-URL: https://github.com/stdlib-js/stdlib/pull/5311
Closes: https://github.com/stdlib-js/stdlib/issues/5305

Reviewed-by: Karan Anand <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 7c6d2b7 into stdlib-js:develop Feb 22, 2025
75 of 76 checks passed
@rishavtarway rishavtarway deleted the fix/#5305 branch February 22, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address commit comments (commit e05da28)

5 participants