Skip to content

Conversation

Neerajpathak07
Copy link
Member

Resolves #5359 .

Description

What is the purpose of this pull request?

This pull request:

  • Fixes C lint errors for a few packages.
  • Suppresses cpp-check for uninit-var and shadow function declaration.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 24, 2025
@Neerajpathak07 Neerajpathak07 changed the title docs: C lint errors docs: fix C lint errors Feb 24, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 24, 2025

Coverage Report

Package Statements Branches Functions Lines
math/base/special/nonfibonacci $\color{green}215/215$
$\color{green}+100.00\%$
$\color{green}12/12$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}215/215$
$\color{green}+100.00\%$
stats/base/dvarm $\color{green}364/364$
$\color{green}+100.00\%$
$\color{green}14/14$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}364/364$
$\color{green}+100.00\%$
stats/base/svariance $\color{green}363/363$
$\color{green}+100.00\%$
$\color{green}14/14$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}363/363$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as draft February 24, 2025 08:53
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review February 24, 2025 08:53
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Feb 24, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 24, 2025
@Neerajpathak07
Copy link
Member Author

Had to close and reopen the PR to pass the CI check for lint PR tittle.

@Neerajpathak07
Copy link
Member Author

@Planeshifter Let's land this in!!

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 2, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

docs: fix C lint errors

PR-URL: https://github.com/stdlib-js/stdlib/pull/5408
Closes: https://github.com/stdlib-js/stdlib/issues/5359

Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 886e85a into stdlib-js:develop Mar 2, 2025
75 of 76 checks passed
PraverBajaj pushed a commit to PraverBajaj/stdlib that referenced this pull request Mar 3, 2025
PR-URL: stdlib-js#5408
Closes: stdlib-js#5359

Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix C lint errors

3 participants