Skip to content

Conversation

AmanBhadkariya
Copy link
Contributor

Resolves #5900.

Description

fixed #5900

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #{{TODO: add issue number}}

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 9, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 9, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/triangular/logcdf $\color{green}356/356$
$\color{green}+100.00\%$
$\color{green}36/36$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}356/356$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Signed-off-by: Philipp Burckhardt <[email protected]>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first PR!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 10, 2025
@Planeshifter Planeshifter changed the title fixed #5900 chore: address commit comments Mar 10, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 10, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 10, 2025

PR Commit Message

chore: address commit comments

PR-URL: https://github.com/stdlib-js/stdlib/pull/5927
Closes: https://github.com/stdlib-js/stdlib/issues/5900

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 2ce745b into stdlib-js:develop Mar 10, 2025
31 of 32 checks passed
@Planeshifter Planeshifter mentioned this pull request Mar 10, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address commit comments (commit be656a1)

3 participants