Skip to content

Conversation

Eternity0207
Copy link
Contributor

Resolves #6238.

Description

What is the purpose of this pull request?

This pull request:

• Fixes the following issue

lib/node_modules/@stdlib/math/base/special/floor10/src/addon.c:22:1: style: Local variable 'stdlib_base_floor10' shadows
outer function [shadowFunction]
STDLIB_MATH_BASE_NAPI_MODULE_D_D( stdlib_base_floor10 )

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Signed-off-by: MANI <[email protected]>
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Mar 21, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/napi/unary $\color{green}153/153$
$\color{green}+100.00\%$
$\color{green}5/5$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}153/153$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

napi_value exports \
) { \
napi_value fcn; \
napi_value fcn_val; \
Copy link
Contributor

@anandkaranubc anandkaranubc Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
napi_value fcn_val; \
napi_value f; \

Thanks @Eternity0207 for pointing this out and fixing it! Much appreciated. Could you please make this change here and elsewhere as well?

Note: The backslashes need to be aligned accordingly.

kgryte added a commit that referenced this pull request Apr 1, 2025
PR-URL: #6481
Closes: #6238
Ref: #6245
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
@kgryte
Copy link
Member

kgryte commented Apr 1, 2025

Ref: #6481

@kgryte kgryte added autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. and removed Needs Review A pull request which needs code review. labels Apr 1, 2025
@stdlib-bot
Copy link
Contributor

Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

@stdlib-bot stdlib-bot closed this Apr 1, 2025
@Eternity0207 Eternity0207 deleted the patch-2 branch October 6, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix C lint errors

4 participants