Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -48,17 +48,17 @@
napi_env env, \
napi_value exports \
) { \
napi_value fcn; \
napi_value fcn_val; \
Copy link
Contributor

@anandkaranubc anandkaranubc Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
napi_value fcn_val; \
napi_value f; \

Thanks @Eternity0207 for pointing this out and fixing it! Much appreciated. Could you please make this change here and elsewhere as well?

Note: The backslashes need to be aligned accordingly.

napi_status status = napi_create_function( \
env, \
"exports", \
NAPI_AUTO_LENGTH, \
stdlib_math_base_napi_d_d_wrapper, \
NULL, \
&fcn \
&fcn_val \
); \
assert( status == napi_ok ); \
return fcn; \
return fcn_val; \
}; \
NAPI_MODULE( NODE_GYP_MODULE_NAME, stdlib_math_base_napi_d_d_init )

Expand Down