Skip to content

Conversation

hrshya
Copy link
Contributor

@hrshya hrshya commented Apr 9, 2025

Resolves none .

Description

What is the purpose of this pull request?

This pull request:

  • replaces manual for loop in examples for math/base/special/floor10, math/base/special/floorf, math/base/special/floorsd, math/base/special/fmod and math/base/special/fmodf packages.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves no related issues.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Apr 9, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Apr 9, 2025

Coverage Report

Package Statements Branches Functions Lines
math/base/special/floor10 $\color{green}193/193$
$\color{green}+100.00\%$
$\color{green}19/19$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}193/193$
$\color{green}+100.00\%$
math/base/special/floorf $\color{green}157/157$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}157/157$
$\color{green}+100.00\%$
math/base/special/floorsd $\color{green}218/218$
$\color{green}+100.00\%$
$\color{green}27/27$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}218/218$
$\color{green}+100.00\%$
math/base/special/fmod $\color{green}183/183$
$\color{green}+100.00\%$
$\color{green}5/5$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}183/183$
$\color{green}+100.00\%$
math/base/special/fmodf $\color{green}188/188$
$\color{green}+100.00\%$
$\color{green}5/5$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}188/188$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@hrshya
Copy link
Contributor Author

hrshya commented Apr 9, 2025

How can I resolve this first_time_greeting ci issue ?

cc: @kgryte

@kgryte
Copy link
Member

kgryte commented Apr 10, 2025

@hrshya Nothing you need to do on your end. @Planeshifter is working to fix it.

@kgryte kgryte added Documentation Improvements, additions, or changes to documentation. and removed Needs Review A pull request which needs code review. labels Apr 10, 2025
@kgryte
Copy link
Member

kgryte commented Apr 10, 2025

Looks like there is a bug in our string/format implementation in which %% fails to render a % symbol. This deviates from expected C99 printf behavior: https://en.cppreference.com/w/c/io/fprintf. That should get fixed in the upstream package so we can unblock this PR.

@kgryte kgryte added the status: Blocked Issue or pull request which is currently blocked. label Apr 10, 2025
@anandkaranubc
Copy link
Contributor

@hrshya This PR will be ready to land once #6695 is merged.

@Planeshifter
Copy link
Member

/stdlib rebase

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 19, 2025
@stdlib-bot
Copy link
Contributor

/stdlib rebase

@Planeshifter, the slash command failed to complete. Please check the workflow logs for details.

View workflow run

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 19, 2025
@Planeshifter
Copy link
Member

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 19, 2025
@Planeshifter Planeshifter removed the status: Blocked Issue or pull request which is currently blocked. label Apr 19, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 19, 2025
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 19, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

docs: replace manual `for` loop in examples

PR-URL: https://github.com/stdlib-js/stdlib/pull/6623

Co-authored-by: Athan Reines <[email protected]>
Co-authored-by: hrshya <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Signed-off-by: Athan <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 76ad4ca into stdlib-js:develop Apr 19, 2025
29 checks passed
@hrshya hrshya deleted the docs/floor10 branch October 11, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements, additions, or changes to documentation. Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants