Skip to content

Conversation

udaykakade25
Copy link
Contributor

Resolves #7023

Description

What is the purpose of this pull request?

This pull request:

  • fix EditorConfig JavaScript lint errors

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels May 18, 2025
Comment on lines 2 to 4
"string": [
"split",
"aliases"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"string": [
"split",
"aliases"
"string": [
"split",
"aliases"

2 space indentation is expected in this here and elsewhere.

Comment on lines 2 to 3
{
"raw": "{{alias}}()\n Returns a pseudorandom number drawn from a uniform distribution.\n\n The default underlying pseudorandom number generator (PRNG) *may* change in\n the future. If exact reproducibility is required, either use the `factory`\n method to explicitly specify a PRNG via the `name` option or use an\n underlying PRNG directly.\n\n Returns\n -------\n r: number\n Pseudorandom number on the interval `[0,1)`.\n\n Examples\n --------\n > var r = {{alias}}();",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here in this whole file

@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label May 19, 2025
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to tools/make/lib/lint/editorconfig.mk are undesired and should be excluded from this PR.
Thanks!

@stdlib-bot stdlib-bot added the Tools Issue or pull request related to project tooling. label May 20, 2025
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label May 20, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label May 20, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented May 20, 2025

PR Commit Message

chore: fix EditorConfig lint errors

PR-URL: https://github.com/stdlib-js/stdlib/pull/7028
Closes: https://github.com/stdlib-js/stdlib/issues/7023

Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Shabareesh Shetty <[email protected]>
Signed-off-by: Uday Kakade <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit c788fc5 into stdlib-js:develop May 20, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Tools Issue or pull request related to project tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix EditorConfig lint errors

4 participants