feat: add ndarray/base/nullary-strided1d

[headlessNode]

---

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

• task: lint_filenames status: passed
• task: lint_editorconfig status: passed
• task: lint_markdown status: passed
• task: lint_package_json status: passed
• task: lint_repl_help status: passed
• task: lint_javascript_src status: passed
• task: lint_javascript_cli status: na
• task: lint_javascript_examples status: passed
• task: lint_javascript_tests status: passed
• task: lint_javascript_benchmarks status: na
• task: lint_python status: na
• task: lint_r status: na
• task: lint_c_src status: na
• task: lint_c_examples status: na
• task: lint_c_benchmarks status: na
• task: lint_c_tests_fixtures status: na
• task: lint_shell status: na
• task: lint_typescript_declarations status: na
• task: lint_typescript_tests status: na
• task: lint_license_headers status: passed ---

Progresses #2656.

Description

What is the purpose of this pull request?

This pull request:

• add ndarray/base/nullary-strided1d

Related Issues

Does this pull request have any related issues?

This pull request:

• progresses [RFC]: achieve ndarray API parity with built-in JavaScript arrays  #2656

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
ndarray/base/nullary-strided1d	$\color{red}1884/2748$ $\color{green}+68.56\%$	$\color{red}20/21$ $\color{green}+95.24\%$	$\color{red}2/22$ $\color{green}+9.09\%$	$\color{red}1884/2748$ $\color{green}+68.56\%$

The above coverage report was generated for the changes in this PR.

[headlessNode]

@kgryte let me know if should go ahead and apply the suggestions above. The suggested change for all is to change input in the description to output, since the function is nullary.

[kgryte]

@headlessNode How about just saying in an ndarray and omitting input/output entirely?

[kgryte]

The input/output qualifier is less applicable here, as the input array is really treated as both.

[headlessNode]

@kgryte Makes sense.

[kgryte]

The main issue with the current implementation is you need to more closely follow unary-strided1d in terms of having both an input and output strategy. It is not enough to simply have an input strategy.

Why? Because the input strategy could be to copy data to a workspace. If the strided array function mutates that data (e.g., sorting), then we need to copy that data back from the workspace to the original input array. Right now, your implementation does not handle that. You only handle the input strategy, but not the output.

In short, "nullary" effectively assumes that a provided ndarray is both an input and an output array.

Accordingly, I suggest copying, more or less, the strategy.js file from unary-strided1d and then updating all your loop kernels accordingly.

[kgryte]

@headlessNode Also, as an aside, I see that you went through each file and added various change requests (over 100 of them). That follow-up is certainly appreciated; however, I might suggest for repeated changes like that, just doing that review in VSCode and pushing up the changes all in one go, potentially by using find-and-replace. In this case, GitHub was not particularly adept at determining that you had resolved all those change requests, requiring me (or someone else) to mark them as "resolved".