Skip to content

feat: add ndarray/base/nullary-strided1d-dispatch-factory #7828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 17, 2025
Merged

feat: add ndarray/base/nullary-strided1d-dispatch-factory #7828

merged 8 commits into from
Sep 17, 2025

Conversation

headlessNode
Copy link
Member

Progresses #2656.

Description

What is the purpose of this pull request?

This pull request:

  • add ndarray/base/nullary-strided1d-dispatch-factory

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@headlessNode headlessNode added Feature Issue or pull request for adding a new feature. GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025). labels Aug 7, 2025
@headlessNode
Copy link
Member Author

Need to merge #7821, #7772 and #7756 first.

@headlessNode headlessNode mentioned this pull request Aug 11, 2025
Closed
@kgryte
Copy link
Member

kgryte commented Sep 10, 2025

@headlessNode I did a good bit of refactoring in #7821. You'll need to update this PR accordingly.

@kgryte
Copy link
Member

kgryte commented Sep 13, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Sep 13, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Sep 13, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Sep 13, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
ndarray/base/nullary-strided1d-dispatch-factory $\color{red}148/184$
$\color{green}+80.43\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{red}0/1$
$\color{green}+0.00\%$ 		$\color{red}148/184$
$\color{green}+80.43\%$

The above coverage report was generated for the changes in this PR.

@headlessNode headlessNode mentioned this pull request Sep 16, 2025
Open
@headlessNode headlessNode marked this pull request as ready for review September 16, 2025 20:02
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Sep 16, 2025
@headlessNode headlessNode requested a review from kgryte September 16, 2025 20:02
@headlessNode
Copy link
Member Author

Lint error expected.

@kgryte
chore: clean-up
b04cfeb 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: skipped
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Sep 17, 2025
@kgryte
Copy link
Member

kgryte commented Sep 17, 2025

As the REPL text lint error is expected, I'll go ahead and merge.

@kgryte kgryte merged commit 724283b into stdlib-js:develop Sep 17, 2025
13 of 14 checks passed
@headlessNode headlessNode deleted the ndarray-nullary1d-dispatch-factory branch September 17, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@headlessNode @kgryte @stdlib-bot