-
-
Notifications
You must be signed in to change notification settings - Fork 990
feat: implement toLocaleString method in dstructs/named-typed-tuple
#8009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement toLocaleString method in dstructs/named-typed-tuple
#8009
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: na
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
|
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
…e/examples/index.js
|
@Gauravkaushik-1206 You can include tests in this PR. Same thing for adding docs, benchmarks, etc. |
…x-of` PR-URL: stdlib-js#8007 Closes: stdlib-js/metr-issue-tracker#71 Ref: stdlib-js#2656 Reviewed-by: Athan Reines <[email protected]>
…x-of` PR-URL: stdlib-js#8008 Closes: stdlib-js/metr-issue-tracker#72 Ref: stdlib-js#2656 Reviewed-by: Athan Reines <[email protected]>
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: na
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
|
docs, benchmarks already include the toLocaleString() and i have included the tests. |
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: na
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
|
any update ?? |
…st-index-of/README.md
…st-index-of/benchmark/benchmark.js
…st-index-of/docs/types/index.d.ts
…st-index-of/examples/index.js
lib/node_modules/@stdlib/dstructs/named-typed-tuple/docs/repl.txt
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
Signed-off-by: Athan <[email protected]>
@kgryte, the slash command failed to complete. Please check the workflow logs for details. |
Signed-off-by: Athan <[email protected]>
lib/node_modules/@stdlib/dstructs/named-typed-tuple/test/test.to_locale_string.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
lib/node_modules/@stdlib/dstructs/named-typed-tuple/test/test.to_locale_string.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
lib/node_modules/@stdlib/dstructs/named-typed-tuple/test/test.to_locale_string.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
lib/node_modules/@stdlib/dstructs/named-typed-tuple/test/test.to_locale_string.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
lib/node_modules/@stdlib/dstructs/named-typed-tuple/test/test.to_locale_string.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
Signed-off-by: Athan <[email protected]>
Signed-off-by: Athan <[email protected]>
lib/node_modules/@stdlib/dstructs/named-typed-tuple/test/test.to_locale_string.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
|
/stdlib merge |
toLocaleString method in dstructs/named-typed-tuple
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
Resolves #6976
Description
This pull request implements the
toLocaleString()function inlib/node_modules/@stdlib/dstructs/named-typed-tuple/lib/main.js,which was flagged by ESLint under the
no-warning-commentsrule.Related Issues
Questions
I have written test cases for this function. Would you like me to include them in this PR or submit them separately?
Other Information
No additional information.
Checklist
@stdlib-js/reviewers