Skip to content

Conversation

Payal-Goswami
Copy link
Contributor

@Payal-Goswami Payal-Goswami commented Sep 5, 2025

Resolves #6976.

Add toLocaleString method to named-typed-tuple

Description

This pull request adds a toLocaleString method to named-typed-tuple instances.
The method provides locale-aware string representations of tuple values, similar
to the existing toString method. For example, large numbers are formatted with
commas or other locale-specific separators.

Changes

  • Implemented toLocaleString in lib/main.js.
  • Added unit tests in test/test.to_locale_string.js to verify functionality.

Questions

No.

Other

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Sep 5, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
dstructs/named-typed-tuple $\color{red}989/1825$
$\color{green}+54.19\%$
$\color{red}24/37$
$\color{green}+64.86\%$
$\color{red}7/41$
$\color{green}+17.07\%$
$\color{red}989/1825$
$\color{green}+54.19\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label Sep 6, 2025
@kgryte kgryte removed the Needs Review A pull request which needs code review. label Sep 8, 2025
@kgryte
Copy link
Member

kgryte commented Sep 8, 2025

The upstream issue has already been resolved in #8009. As such, I'll go ahead and close.

Thank you again for your interest in stdlib, and we look forward to your future contributions!

@kgryte kgryte closed this Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Potential Duplicate There might be another pull request resolving the same issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors
3 participants