Fixed Javacript liniting issue

[SuYaSh-PaThAk04]

Fixing the liniting issue

Resolves #8100 .

Description

What is the purpose of this pull request?

This pull request:

• Previously, the onDrain callback was nested inside onCommand. This violated the project’s linting rule stdlib/no-unnecessary-nested-functions, which discourages unnecessary nested functions because they can:

Capture more variables than needed,

Hurt readability, and

Complicate linting/analysis.

Before (nested function):

function onCommand() {
pres._repl.once('drain', onDrain);

function onDrain() {
pres.first().show();
}
}

After (fixed):

function onCommand() {
// bind pres so onDrain still has access to it
pres._repl.once('drain', () => onDrain(pres));
}

function onDrain(pres) {
pres.first().show();
}

Related Issues

Does this pull request have any related issues?

This pull request:

• resolves Fix JavaScript lint errors #6704

Questions

Any questions for reviewers of this pull request?

No.

Other

onDrain moved from a nested function inside onCommand to its own top-level private function.

Used an arrow function wrapper () => onDrain(pres) to pass pres as an argument, keeping the same behavior.

Satisfies linting by removing the unnecessary nested function.

Keeps onDrain reusable and cleaner to test/document.

Maintains the original behavior: waiting for the drain event before showing the first slide.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[stdlib-bot]

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

• Please read our contributing guidelines if you haven't already.
• For development guidance, refer to the development guide.

Next Steps

1. A project maintainer will approve GitHub Actions workflows for your PR.
2. All CI checks must pass before your submission can be fully reviewed.
3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

• Contributing Guidelines
• Development Guide
• Gitter channel
• make rules for running examples
• make rules for running unit tests
• make rules for running benchmarks

[stdlib-bot]

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

1. Please read our contributing guidelines.

2. Update your pull request description to include this checked box:

   - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

• The developer's certificate of origin
• Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

[stdlib-bot]

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

1. Please read our contributing guidelines.

2. Update your pull request description to include this checked box:

   - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

• The developer's certificate of origin
• Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

[Planeshifter]

Resolved via #8111