Skip to content

refactor: move onDrain function to outer scope #8111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2025
Merged

refactor: move onDrain function to outer scope #8111

merged 1 commit into from
Sep 24, 2025

Conversation

Payal-Goswami
Copy link
Contributor

Resolves #8100.

Description

This pull request:

  • fixes a linting issue in lib/node_modules/@stdlib/repl/presentation/lib/commands/first.js.
  • Moved the nested onDrain function to the outer function scope.

Related Issues

This pull request:

Questions

No.

Other

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added REPL Issue or pull request specific to the project REPL. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. Potential Duplicate There might be another pull request resolving the same issue. labels Sep 20, 2025
@Planeshifter Planeshifter changed the title move onDrain function to outer scope in first.js refactor: move onDrain function to outer scope Sep 24, 2025
Planeshifter
Planeshifter approved these changes Sep 24, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Sep 24, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Sep 24, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Sep 24, 2025 •
edited by Planeshifter
Loading

PR Commit Message

refactor: move `onDrain` function to outer scope

PR-URL: https://github.com/stdlib-js/stdlib/pull/8111
Closes: https://github.com/stdlib-js/stdlib/issues/8100

Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 291b901 into stdlib-js:develop Sep 24, 2025
103 of 106 checks passed
@Planeshifter Planeshifter mentioned this pull request Sep 24, 2025
Closed
1 task
@Payal-Goswami Payal-Goswami deleted the fix-lint-errors-8100 branch September 29, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue. Potential Duplicate There might be another pull request resolving the same issue. Ready To Merge A pull request which is ready to be merged. REPL Issue or pull request specific to the project REPL.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants

@Payal-Goswami @stdlib-bot @Planeshifter