-
-
Notifications
You must be signed in to change notification settings - Fork 903
chore: fix JavaScript lint errors (issue #8225) #8226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
- Replace 'new Array(shape.length+1)' with array literal and length assignment - Fixes stdlib/no-new-array linting error in test.instance.set_nd.js - Maintains same functionality while adhering to project coding standards - Resolves JavaScript linting failure detected in CI workflow
👋 Hi there! 👋 And thank you for opening your first pull request! We will review it shortly. 🏃 💨 Getting Started
Next Steps
Running Tests LocallyYou can use # Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"
# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*" If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR. If you have any further questions while waiting for a response, please join our Gitter channel to chat with project maintainers and other community members. We appreciate your contribution! Documentation Links |
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the desired change; see how the lint error
Using the
new Array()
constructor is not allowed; use an array literal with push instead
requests use ofpush
to add elements to the array.
Description
Fixes JavaScript linting error in
@stdlib/ndarray/ctor
test file by replacingnew Array()
constructor with array literal.Changes
new Array(shape.length+1)
with array literal and explicit length assignmentstdlib/no-new-array
ESLint rule violationRelated Issues
Resolves the linting failure detected in CI workflow:
https://github.com/stdlib-js/stdlib/actions/runs/18392323945
Testing
Checklist