-
-
Notifications
You must be signed in to change notification settings - Fork 903
chore: fix JavaScript lint errors (issue #8227) #8228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
Hi, I noticed that we could also generate the array using @stdlib/random/array/randu (e.g., var arr = randu(100);) instead of manually pushing random numbers in a loop. However, I kept the explicit loop since it seems to better illustrate how someByRight() traverses the array from right to left. Please let me know if you’d prefer switching to randu(). |
That would be better; would you mind changing the example code to use the array random PRNG package instead, please? In general, we want to move away from having for-loops in our example code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please refactor to use the array PRNG equivalent. Also notice that the example code in the README.md
file currently contains a duplicated var arr
; this should be rectified as part of the refactoring. Thanks!
Resolves #8227
Description
This pull request:
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers