Skip to content

feat: add truncate-middle-code-point string package #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat: add truncate-middle-code-point string package #1119

wants to merge 4 commits into from

Conversation

steff456
Copy link
Contributor

@steff456 steff456 commented Oct 30, 2023 •
edited
Loading

Part of #1062

Description

What is the purpose of this pull request?

This pull request:

  • Adds @stdlib/string/base/truncate-middle-code-point

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

This PR depends on the packages,

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@steff456 steff456 requested a review from kgryte October 30, 2023 19:27
@steff456 steff456 self-assigned this Oct 30, 2023
@steff456 steff456 mentioned this pull request Oct 30, 2023
Open
1 task
kgryte
kgryte requested changes Oct 31, 2023
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should refactor to require seq as a mandatory argument.

kgryte
kgryte reviewed Nov 10, 2023
View reviewed changes
lib/node_modules/@stdlib/string/base/truncate-middle-code-point/README.md
@@ -0,0 +1,92 @@
<!--
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package needs to be renamed to plural.

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities. Needs Changes Pull request which needs changes before being merged. labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@steff456 steff456

Labels

Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged. Utilities Issue or pull request concerning general utilities.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@steff456 @kgryte