-
-
Notifications
You must be signed in to change notification settings - Fork 917
feat: add fuzzy matching algorithm for tab completions #1855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Snehil-Shah
wants to merge
27
commits into
stdlib-js:develop
Choose a base branch
from
Snehil-Shah:repl-fuzzy
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
dc73372
feat: add fuzzy matching algorithm for tab completions
Snehil-Shah 3cae6a7
refactor: fix function jsdoc
Snehil-Shah abe7525
Merge branch 'stdlib-js:develop' into repl-fuzzy
Snehil-Shah dcb6014
feat: rewrite the completer engine
Snehil-Shah bef5dd3
feat: improve fuzzy algorithm and sort by relevancy
Snehil-Shah 0aee34d
feat: add support for highlighted completions in terminal mode
Snehil-Shah 7efe1a7
fix: wrong completion previews displayed for fuzzy completion
Snehil-Shah b0ca5c1
fix: suggestions
Snehil-Shah 7cc9270
feat: new tab completions UI with navigation
Snehil-Shah 24da634
refactor: move `fuzzyMatch` to a module & don't fuzzy match for previews
Snehil-Shah 6818055
fix: changes requested
Snehil-Shah 95a72a4
Merge branch 'develop' into repl-fuzzy
Snehil-Shah 0c8b11a
style: lint merged changes
Snehil-Shah 6b7dc99
feat: add a setting to control fuzzy completions
Snehil-Shah 237fb7f
fix: limit height of completions & fix completions with prefixes
Snehil-Shah 576f402
feat: fuzzy completions only when no exact completions
Snehil-Shah 89b5001
fix: bug in completer
Snehil-Shah c464944
test: add tests for tab completions
Snehil-Shah 6d6d7c9
docs: fix test name and comments
Snehil-Shah 2c15d15
fix: tune fuzzy algorithm
Snehil-Shah 0e54cf5
docs: document setting
Snehil-Shah 7128fac
Merge branch 'develop' into repl-fuzzy
Snehil-Shah fa22afb
fix: abnormal completer behavior
Snehil-Shah 7b8074a
refactor: move flag to the completer engine namespace
Snehil-Shah cc2f3c5
refactor: abstract logics into private methods
Snehil-Shah 85efce4
fix: make completer `SIGWINCH` aware
Snehil-Shah 023c31a
test: update tests for TTY
Snehil-Shah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep the prior implementation, as well. Move the fuzzy match filtering to a separate file. The ability to use prefix or fuzzy completion should be user controlled. Additionally, for completion previews, we should not use the completions generated by the fuzzy completer. They should be completions generated by the previous completer logic, as fuzzy completion has an increased perf penalty and preview completions need to, by necessity, have a smaller list of completion candidates to process.