Skip to content

Conversation

headlessNode
Copy link
Member

Progresses #2656.

Description

What is the purpose of this pull request?

This pull request:

  • adds base implementation of the to-reversed function.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Sep 7, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for working on this @headlessNode!

I also made a few small changes to ndarray/base/reverse to simplify the type definitions.

@kgryte kgryte merged commit 8bcb738 into stdlib-js:develop Sep 7, 2024
9 checks passed
@headlessNode headlessNode deleted the ndarray-base-toReversed branch September 7, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants