Skip to content

feat: add C implementation for ndarray for blas/base/srot and blas/base/drot #2896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 21, 2024
Merged

feat: add C implementation for ndarray for blas/base/srot and blas/base/drot #2896

merged 12 commits into from
Sep 21, 2024

Conversation

aman-095
Copy link
Member

@aman-095 aman-095 commented Sep 12, 2024 •
edited
Loading

Progresses #2039.

Description

What is the purpose of this pull request?

This pull request adds C implementation to support ndarray blas/base/srot and blas/base/drot.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Sep 12, 2024
@aman-095 aman-095 added the C Issue involves or relates to C. label Sep 12, 2024
@aman-095 aman-095 changed the title refactor: add C implementation for ndarray for blas/base/srot refactor: add C implementation for ndarray for blas/base/srot and blas/base/drot Sep 12, 2024
@kgryte kgryte added the Needs Review A pull request which needs code review. label Sep 18, 2024
kgryte
kgryte reviewed Sep 19, 2024
View reviewed changes
kgryte
kgryte reviewed Sep 19, 2024
View reviewed changes
kgryte
kgryte reviewed Sep 19, 2024
View reviewed changes
kgryte
kgryte reviewed Sep 19, 2024
View reviewed changes
kgryte
kgryte reviewed Sep 19, 2024
View reviewed changes
kgryte
kgryte reviewed Sep 19, 2024
View reviewed changes
kgryte
kgryte reviewed Sep 19, 2024
View reviewed changes
kgryte
kgryte reviewed Sep 19, 2024
View reviewed changes
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Sep 19, 2024
@aman-095 aman-095 added Feature Issue or pull request for adding a new feature. and removed Needs Changes Pull request which needs changes before being merged. labels Sep 20, 2024
kgryte
kgryte reviewed Sep 21, 2024
View reviewed changes
kgryte
kgryte reviewed Sep 21, 2024
View reviewed changes
kgryte
kgryte approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @aman-095!

@kgryte kgryte merged commit 57d03ad into stdlib-js:develop Sep 21, 2024
10 checks passed
@kgryte kgryte changed the title refactor: add C implementation for ndarray for blas/base/srot and blas/base/drot feat: add C implementation for ndarray for blas/base/srot and blas/base/drot Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Feature Issue or pull request for adding a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aman-095 @kgryte @stdlib-bot