Skip to content

Conversation

gunjjoshi
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

float stdlib_base_nanmaxf( const float x, const float y )

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Math Issue or pull request specific to math functionality. label Oct 26, 2024
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Oct 26, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @gunjjoshi!

@kgryte kgryte merged commit 84b8294 into stdlib-js:develop Oct 26, 2024
10 checks passed
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Nov 9, 2024
PR-URL: stdlib-js#3035
Ref: stdlib-js#649
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
aayush0325 pushed a commit to aayush0325/stdlib that referenced this pull request Nov 11, 2024
PR-URL: stdlib-js#3035
Ref: stdlib-js#649
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants