feat: add support for stack for blas/scopy
#3095
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
added
the
BLAS
kgryte
reviewed
Nov 17, 2024
| // MODULES // | ||
|
|
||
| var base = require( '@stdlib/blas/base/scopy' ).ndarray; | ||
| var factory = require( '@stdlib/blas/tools/swap-factory' ); |
There was a problem hiding this comment.
@aman-095 I understand why you are attempting to reuse swap-factory; however, I'd advise not doing that, as the behavior is not guaranteed to be the same, as mentioned in the test file below.
There was a problem hiding this comment.
You need to actually create tools/copy-factory.
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
Nov 17, 2024
| } | ||
| }); | ||
|
|
||
| tape( 'the function throws an error if provided a first argument which is a read-only ndarray', function test( t ) { |
There was a problem hiding this comment.
@aman-095 This is incorrect. The first argument is not mutated, so it can be read-only. This test passes because you chose to use swap-factory, but that tool is designed for different behavior.
kgryte
added
the
Needs Changes
|
/stdlib update-copyright-years |
stdlib-bot
added
the
bot: In Progress
stdlib-bot
removed
the
bot: In Progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds support for stacks for
blas/scopy.Related Issues
None.
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers