-
-
Notifications
You must be signed in to change notification settings - Fork 907
feat: add C implementation for math/base/special/minmax
#3112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 50 commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
020951d
secant functionality added
AbhijitRaut04 cd658c7
test cases checked
AbhijitRaut04 61dd8a5
huge_negative.json unformat
AbhijitRaut04 1a3044c
Examples fixed
AbhijitRaut04 4f9cfcd
Merge branch 'stdlib-js:develop' into develop
AbhijitRaut04 20d3800
Merge branch 'develop' of https://github.com/AbhijitRaut04/stdlib int…
AbhijitRaut04 a7396d8
Apply suggestions from code review
kgryte 7a2c270
Spacing conventions followed and required changes made
AbhijitRaut04 d0ebc38
Merge branch 'develop' of https://github.com/AbhijitRaut04/stdlib int…
AbhijitRaut04 2733e3e
Merge branch 'stdlib-js:develop' into develop
AbhijitRaut04 52900e0
necessary changes made
AbhijitRaut04 5ab6d39
Merge branch 'develop' of https://github.com/AbhijitRaut04/stdlib int…
AbhijitRaut04 6f04f94
chore: apply suggestions from code review
Planeshifter a630f41
chore: update relative path
Planeshifter 2cb28a7
Merge branch 'stdlib-js:develop' into develop
AbhijitRaut04 c30cdec
Merge branch 'stdlib-js:develop' into develop
AbhijitRaut04 0735981
add c implementation for minmax
AbhijitRaut04 0d34bb5
example.out
AbhijitRaut04 cbaa9a0
add manifest.json
AbhijitRaut04 89d15a4
pyp files added
AbhijitRaut04 64bb538
dependency resolved
AbhijitRaut04 72be084
removed minmax dependency
AbhijitRaut04 8b45444
return datatype changed
AbhijitRaut04 0339052
licensce years corrected
AbhijitRaut04 8f1f317
years corrected
AbhijitRaut04 6ca0a3f
unary to binary converted
AbhijitRaut04 3346b22
update
AbhijitRaut04 dd3e865
removed cephes
AbhijitRaut04 d5b8312
Merge branch 'stdlib-js:develop' into develop
AbhijitRaut04 67e9010
manifest update
AbhijitRaut04 bf6f9e0
Merge branch 'develop' of https://github.com/AbhijitRaut04/stdlib int…
AbhijitRaut04 d800f25
manifest updated
AbhijitRaut04 9035a6c
_
AbhijitRaut04 c43128a
update package.json
AbhijitRaut04 674fdd0
''
AbhijitRaut04 da8bf36
add dynamic allocation for result
AbhijitRaut04 4be1efa
implementation changed
AbhijitRaut04 4f592a2
changes updated
AbhijitRaut04 0f722f7
void changed to double
AbhijitRaut04 fbe9c46
return
AbhijitRaut04 9e9c7fa
examples updated
AbhijitRaut04 3c8ec0e
wrapper added for minmax
AbhijitRaut04 0598ee5
wrapper modified
AbhijitRaut04 c89beac
benchs examples
AbhijitRaut04 1f95c46
return changed to double instead double *
AbhijitRaut04 a4dbf3c
Merge branch 'stdlib-js:develop' into develop
AbhijitRaut04 6a0ad2f
native.js updated
AbhijitRaut04 1ebac1d
Merge branch 'develop' of https://github.com/AbhijitRaut04/stdlib int…
AbhijitRaut04 8baa0ac
Merge branch 'stdlib-js:develop' into develop
AbhijitRaut04 d44c982
Merge remote-tracking branch 'upstream/develop' into develop
stdlib-bot ab4c30f
changes made
AbhijitRaut04 480eca1
Merge branch 'develop' of https://github.com/AbhijitRaut04/stdlib int…
AbhijitRaut04 ce381ba
changes made
AbhijitRaut04 ea1137f
changes reverted
AbhijitRaut04 a84f7ee
native implementation updated
AbhijitRaut04 42e7d33
update native
AbhijitRaut04 6770168
revrt
AbhijitRaut04 47fe186
revert
AbhijitRaut04 0235838
addon.c
AbhijitRaut04 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60 changes: 60 additions & 0 deletions
60
lib/node_modules/@stdlib/math/base/special/minmax/benchmark/benchmark.native.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
/** | ||
* @license Apache-2.0 | ||
* | ||
* Copyright (c) 2024 The Stdlib Authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
// MODULES // | ||
|
||
var resolve = require( 'path' ).resolve; | ||
var bench = require( '@stdlib/bench' ); | ||
var randu = require( '@stdlib/random/base/randu' ); | ||
var isnan = require( '@stdlib/math/base/assert/is-nan' ); | ||
var tryRequire = require( '@stdlib/utils/try-require' ); | ||
var pkg = require( './../package.json' ).name; | ||
|
||
|
||
// VARIABLES // | ||
|
||
var minmax = tryRequire( resolve( __dirname, './../lib/native.js' ) ); | ||
var opts = { | ||
'skip': ( minmax instanceof Error ) | ||
}; | ||
|
||
|
||
// MAIN // | ||
|
||
bench( pkg+'::native', opts, function benchmark( b ) { | ||
var x; | ||
var y; | ||
var i; | ||
|
||
b.tic(); | ||
for ( i = 0; i < b.iterations; i++ ) { | ||
x = ( randu() * 20.0 ) - 10.0; | ||
y = minmax( x ); | ||
if ( isnan( y ) ) { | ||
b.fail( 'should not return NaN' ); | ||
} | ||
} | ||
b.toc(); | ||
if ( isnan( y ) ) { | ||
b.fail( 'should not return NaN' ); | ||
} | ||
b.pass( 'benchmark finished' ); | ||
b.end(); | ||
}); |
146 changes: 146 additions & 0 deletions
146
lib/node_modules/@stdlib/math/base/special/minmax/benchmark/c/native/Makefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,146 @@ | ||
#/ | ||
# @license Apache-2.0 | ||
# | ||
# Copyright (c) 2024 The Stdlib Authors. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
#/ | ||
|
||
# VARIABLES # | ||
|
||
ifndef VERBOSE | ||
QUIET := @ | ||
else | ||
QUIET := | ||
endif | ||
|
||
# Determine the OS ([1][1], [2][2]). | ||
# | ||
# [1]: https://en.wikipedia.org/wiki/Uname#Examples | ||
# [2]: http://stackoverflow.com/a/27776822/2225624 | ||
OS ?= $(shell uname) | ||
ifneq (, $(findstring MINGW,$(OS))) | ||
OS := WINNT | ||
else | ||
ifneq (, $(findstring MSYS,$(OS))) | ||
OS := WINNT | ||
else | ||
ifneq (, $(findstring CYGWIN,$(OS))) | ||
OS := WINNT | ||
else | ||
ifneq (, $(findstring Windows_NT,$(OS))) | ||
OS := WINNT | ||
endif | ||
endif | ||
endif | ||
endif | ||
|
||
# Define the program used for compiling C source files: | ||
ifdef C_COMPILER | ||
CC := $(C_COMPILER) | ||
else | ||
CC := gcc | ||
endif | ||
|
||
# Define the command-line options when compiling C files: | ||
CFLAGS ?= \ | ||
-std=c99 \ | ||
-O3 \ | ||
-Wall \ | ||
-pedantic | ||
|
||
# Determine whether to generate position independent code ([1][1], [2][2]). | ||
# | ||
# [1]: https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#Code-Gen-Options | ||
# [2]: http://stackoverflow.com/questions/5311515/gcc-fpic-option | ||
ifeq ($(OS), WINNT) | ||
fPIC ?= | ||
else | ||
fPIC ?= -fPIC | ||
endif | ||
|
||
# List of includes (e.g., `-I /foo/bar -I /beep/boop/include`): | ||
INCLUDE ?= | ||
|
||
# List of source files: | ||
SOURCE_FILES ?= | ||
|
||
# List of libraries (e.g., `-lopenblas -lpthread`): | ||
LIBRARIES ?= | ||
|
||
# List of library paths (e.g., `-L /foo/bar -L /beep/boop`): | ||
LIBPATH ?= | ||
|
||
# List of C targets: | ||
c_targets := benchmark.out | ||
|
||
|
||
# RULES # | ||
|
||
#/ | ||
# Compiles source files. | ||
# | ||
# @param {string} [C_COMPILER] - C compiler (e.g., `gcc`) | ||
# @param {string} [CFLAGS] - C compiler options | ||
# @param {(string|void)} [fPIC] - compiler flag determining whether to generate position independent code (e.g., `-fPIC`) | ||
# @param {string} [INCLUDE] - list of includes (e.g., `-I /foo/bar -I /beep/boop/include`) | ||
# @param {string} [SOURCE_FILES] - list of source files | ||
# @param {string} [LIBPATH] - list of library paths (e.g., `-L /foo/bar -L /beep/boop`) | ||
# @param {string} [LIBRARIES] - list of libraries (e.g., `-lopenblas -lpthread`) | ||
# | ||
# @example | ||
# make | ||
# | ||
# @example | ||
# make all | ||
#/ | ||
all: $(c_targets) | ||
|
||
.PHONY: all | ||
|
||
#/ | ||
# Compiles C source files. | ||
# | ||
# @private | ||
# @param {string} CC - C compiler (e.g., `gcc`) | ||
# @param {string} CFLAGS - C compiler options | ||
# @param {(string|void)} fPIC - compiler flag determining whether to generate position independent code (e.g., `-fPIC`) | ||
# @param {string} INCLUDE - list of includes (e.g., `-I /foo/bar`) | ||
# @param {string} SOURCE_FILES - list of source files | ||
# @param {string} LIBPATH - list of library paths (e.g., `-L /foo/bar`) | ||
# @param {string} LIBRARIES - list of libraries (e.g., `-lopenblas`) | ||
#/ | ||
$(c_targets): %.out: %.c | ||
$(QUIET) $(CC) $(CFLAGS) $(fPIC) $(INCLUDE) -o $@ $(SOURCE_FILES) $< $(LIBPATH) -lm $(LIBRARIES) | ||
|
||
#/ | ||
# Runs compiled benchmarks. | ||
# | ||
# @example | ||
# make run | ||
#/ | ||
run: $(c_targets) | ||
$(QUIET) ./$< | ||
|
||
.PHONY: run | ||
|
||
#/ | ||
# Removes generated files. | ||
# | ||
# @example | ||
# make clean | ||
#/ | ||
clean: | ||
$(QUIET) -rm -f *.o *.out | ||
|
||
.PHONY: clean |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.