Skip to content

refactor: replace built-in with fmod in math/base/assert/is-prime #3124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 17, 2024
Merged

refactor: replace built-in with fmod in math/base/assert/is-prime #3124

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f5e8ad
refactor: replace built-in with fmod
gunjjoshi Nov 16, 2024
bd15af3
Update main.c
gunjjoshi Nov 17, 2024
25b588e
Update main.c
gunjjoshi Nov 17, 2024
e5ad6ff
Merge branch 'develop' into is-prime
stdlib-bot Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/node_modules/@stdlib/math/base/assert/is-prime/benchmark/c/native/benchmark.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,15 +92,18 @@ static double rand_double( void ) {
*/
static double benchmark( void ) {
double elapsed;
double x;
double x[ 100 ];
double t;
bool b;
int i;

for ( i = 0; i < 100; i++ ) {
x[ i ] = ( 200.0 * rand_double() );
}

t = tic();
for ( i = 0; i < ITERATIONS; i++ ) {
x = ( rand_double() * 200.0 );
b = stdlib_base_is_prime( x );
b = stdlib_base_is_prime( x[ i % 100 ] );
if ( b != true && b != false ) {
printf( "should return either true or false\n" );
break;
Expand Down
42 changes: 40 additions & 2 deletions lib/node_modules/@stdlib/math/base/assert/is-prime/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
{
"options": {},
"options": {
"task": "build"
},
"fields": [
{
"field": "src",
Expand All @@ -24,6 +26,7 @@
],
"confs": [
{
"task": "build",
"src": [
"./src/main.c"
],
Expand All @@ -35,7 +38,42 @@
"dependencies": [
"@stdlib/math/base/special/sqrt",
"@stdlib/math/base/special/floor",
"@stdlib/constants/float64/max-safe-integer"
"@stdlib/constants/float64/max-safe-integer",
"@stdlib/math/base/special/fmod"
]
},
{
"task": "benchmark",
"src": [
"./src/main.c"
],
"include": [
"./include"
],
"libraries": [],
"libpath": [],
"dependencies": [
"@stdlib/math/base/special/sqrt",
"@stdlib/math/base/special/floor",
"@stdlib/constants/float64/max-safe-integer",
"@stdlib/math/base/special/fmod"
]
},
{
"task": "examples",
"src": [
"./src/main.c"
],
"include": [
"./include"
],
"libraries": [],
"libpath": [],
"dependencies": [
"@stdlib/math/base/special/sqrt",
"@stdlib/math/base/special/floor",
"@stdlib/constants/float64/max-safe-integer",
"@stdlib/math/base/special/fmod"
]
}
]
Expand Down
105 changes: 53 additions & 52 deletions lib/node_modules/@stdlib/math/base/assert/is-prime/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include "stdlib/math/base/special/sqrt.h"
#include "stdlib/math/base/special/floor.h"
#include "stdlib/constants/float64/max_safe_integer.h"
#include "stdlib/math/base/special/fmod.h"
#include <stdint.h>
#include <math.h>

Expand Down Expand Up @@ -54,23 +55,23 @@ bool stdlib_base_is_prime( const double x ) {
return ( x > 1.0 ); // primes: 2.0, 3.0
}
// Check whether the number is even...
if ( x > STDLIB_CONSTANT_FLOAT64_MAX_SAFE_INTEGER || ( fmod( x, 2.0 ) ) == 0.0 ) {
if ( x > STDLIB_CONSTANT_FLOAT64_MAX_SAFE_INTEGER || ( stdlib_base_fmod( x, 2.0 ) ) == 0.0 ) {
return false;
}
// Check for small primes...
if ( x < 9.0 ) {
return true; // primes: 5.0, 7.0
}
// Check whether the number is evenly divisible by `3`...
if ( fmod( x, 3.0 ) == 0.0 ) { // TODO: replace fmod usage once we have a stdlib equivalent
if ( stdlib_base_fmod( x, 3.0 ) == 0.0 ) {
return false;
}
// Check whether the number is evenly divisible by `5`...
if ( fmod( x, 5.0 ) == 0.0 ) {
if ( stdlib_base_fmod( x, 5.0 ) == 0.0 ) {
return false;
}
// Check whether the number is evenly divisible by `7`...
if ( fmod( x, 7.0 ) == 0.0 ) {
if ( stdlib_base_fmod( x, 7.0 ) == 0.0 ) {
return false;
}
// Check whether the number is a prime number in the wheel...
Expand All @@ -83,54 +84,54 @@ bool stdlib_base_is_prime( const double x ) {
N = stdlib_base_floor( stdlib_base_sqrt( x ) );
for ( i = 11; i <= N; i += 210 ) {
if (
fmod( x, i ) == 0.0 || // 11
fmod( x, ( i + 2 ) ) == 0.0 || // 13
fmod( x, ( i + 6 ) ) == 0.0 || // 17
fmod( x, ( i + 8 ) ) == 0.0 || // 19
fmod( x, ( i + 12 ) ) == 0.0 || // 23
fmod( x, ( i + 18 ) ) == 0.0 || // 29
fmod( x, ( i + 20 ) ) == 0.0 || // 31
fmod( x, ( i + 26 ) ) == 0.0 || // 37
fmod( x, ( i + 30 ) ) == 0.0 || // 41
fmod( x, ( i + 32 ) ) == 0.0 || // 43
fmod( x, ( i + 36 ) ) == 0.0 || // 47
fmod( x, ( i + 42 ) ) == 0.0 || // 53
fmod( x, ( i + 48 ) ) == 0.0 || // 59
fmod( x, ( i + 50 ) ) == 0.0 || // 61
fmod( x, ( i + 56 ) ) == 0.0 || // 67
fmod( x, ( i + 60 ) ) == 0.0 || // 71
fmod( x, ( i + 62 ) ) == 0.0 || // 73
fmod( x, ( i + 68 ) ) == 0.0 || // 79
fmod( x, ( i + 72 ) ) == 0.0 || // 83
fmod( x, ( i + 78 ) ) == 0.0 || // 89
fmod( x, ( i + 86 ) ) == 0.0 || // 97
fmod( x, ( i + 90 ) ) == 0.0 || // 101
fmod( x, ( i + 92 ) ) == 0.0 || // 103
fmod( x, ( i + 96 ) ) == 0.0 || // 107
fmod( x, ( i + 98 ) ) == 0.0 || // 109
fmod( x, ( i + 102 ) ) == 0.0 || // 113
fmod( x, ( i + 110 ) ) == 0.0 || // 121 (relatively prime)
fmod( x, ( i + 116 ) ) == 0.0 || // 127
fmod( x, ( i + 120 ) ) == 0.0 || // 131
fmod( x, ( i + 126 ) ) == 0.0 || // 137
fmod( x, ( i + 128 ) ) == 0.0 || // 139
fmod( x, ( i + 132 ) ) == 0.0 || // 143 (relatively prime)
fmod( x, ( i + 138 ) ) == 0.0 || // 149
fmod( x, ( i + 140 ) ) == 0.0 || // 151
fmod( x, ( i + 146 ) ) == 0.0 || // 157
fmod( x, ( i + 152 ) ) == 0.0 || // 163
fmod( x, ( i + 156 ) ) == 0.0 || // 167
fmod( x, ( i + 158 ) ) == 0.0 || // 169 (relatively prime)
fmod( x, ( i + 162 ) ) == 0.0 || // 173
fmod( x, ( i + 168 ) ) == 0.0 || // 179
fmod( x, ( i + 170 ) ) == 0.0 || // 181
fmod( x, ( i + 176 ) ) == 0.0 || // 187 (relatively prime)
fmod( x, ( i + 180 ) ) == 0.0 || // 191
fmod( x, ( i + 182 ) ) == 0.0 || // 193
fmod( x, ( i + 186 ) ) == 0.0 || // 197
fmod( x, ( i + 188 ) ) == 0.0 || // 199
fmod( x, ( i + 198 ) ) == 0.0 || // 209 (relatively prime)
fmod( x, ( i + 200 ) ) == 0.0 // 211
stdlib_base_fmod( x, i ) == 0.0 || // 11
stdlib_base_fmod( x, ( i + 2 ) ) == 0.0 || // 13
stdlib_base_fmod( x, ( i + 6 ) ) == 0.0 || // 17
stdlib_base_fmod( x, ( i + 8 ) ) == 0.0 || // 19
stdlib_base_fmod( x, ( i + 12 ) ) == 0.0 || // 23
stdlib_base_fmod( x, ( i + 18 ) ) == 0.0 || // 29
stdlib_base_fmod( x, ( i + 20 ) ) == 0.0 || // 31
stdlib_base_fmod( x, ( i + 26 ) ) == 0.0 || // 37
stdlib_base_fmod( x, ( i + 30 ) ) == 0.0 || // 41
stdlib_base_fmod( x, ( i + 32 ) ) == 0.0 || // 43
stdlib_base_fmod( x, ( i + 36 ) ) == 0.0 || // 47
stdlib_base_fmod( x, ( i + 42 ) ) == 0.0 || // 53
stdlib_base_fmod( x, ( i + 48 ) ) == 0.0 || // 59
stdlib_base_fmod( x, ( i + 50 ) ) == 0.0 || // 61
stdlib_base_fmod( x, ( i + 56 ) ) == 0.0 || // 67
stdlib_base_fmod( x, ( i + 60 ) ) == 0.0 || // 71
stdlib_base_fmod( x, ( i + 62 ) ) == 0.0 || // 73
stdlib_base_fmod( x, ( i + 68 ) ) == 0.0 || // 79
stdlib_base_fmod( x, ( i + 72 ) ) == 0.0 || // 83
stdlib_base_fmod( x, ( i + 78 ) ) == 0.0 || // 89
stdlib_base_fmod( x, ( i + 86 ) ) == 0.0 || // 97
stdlib_base_fmod( x, ( i + 90 ) ) == 0.0 || // 101
stdlib_base_fmod( x, ( i + 92 ) ) == 0.0 || // 103
stdlib_base_fmod( x, ( i + 96 ) ) == 0.0 || // 107
stdlib_base_fmod( x, ( i + 98 ) ) == 0.0 || // 109
stdlib_base_fmod( x, ( i + 102 ) ) == 0.0 || // 113
stdlib_base_fmod( x, ( i + 110 ) ) == 0.0 || // 121 (relatively prime)
stdlib_base_fmod( x, ( i + 116 ) ) == 0.0 || // 127
stdlib_base_fmod( x, ( i + 120 ) ) == 0.0 || // 131
stdlib_base_fmod( x, ( i + 126 ) ) == 0.0 || // 137
stdlib_base_fmod( x, ( i + 128 ) ) == 0.0 || // 139
stdlib_base_fmod( x, ( i + 132 ) ) == 0.0 || // 143 (relatively prime)
stdlib_base_fmod( x, ( i + 138 ) ) == 0.0 || // 149
stdlib_base_fmod( x, ( i + 140 ) ) == 0.0 || // 151
stdlib_base_fmod( x, ( i + 146 ) ) == 0.0 || // 157
stdlib_base_fmod( x, ( i + 152 ) ) == 0.0 || // 163
stdlib_base_fmod( x, ( i + 156 ) ) == 0.0 || // 167
stdlib_base_fmod( x, ( i + 158 ) ) == 0.0 || // 169 (relatively prime)
stdlib_base_fmod( x, ( i + 162 ) ) == 0.0 || // 173
stdlib_base_fmod( x, ( i + 168 ) ) == 0.0 || // 179
stdlib_base_fmod( x, ( i + 170 ) ) == 0.0 || // 181
stdlib_base_fmod( x, ( i + 176 ) ) == 0.0 || // 187 (relatively prime)
stdlib_base_fmod( x, ( i + 180 ) ) == 0.0 || // 191
stdlib_base_fmod( x, ( i + 182 ) ) == 0.0 || // 193
stdlib_base_fmod( x, ( i + 186 ) ) == 0.0 || // 197
stdlib_base_fmod( x, ( i + 188 ) ) == 0.0 || // 199
stdlib_base_fmod( x, ( i + 198 ) ) == 0.0 || // 209 (relatively prime)
stdlib_base_fmod( x, ( i + 200 ) ) == 0.0 // 211
) {
return false;
}
Expand Down
Loading