Skip to content

refactor: replace fabs with stdlib_base_abs in C implementation of blas/ext/base/dapxsumkbn #3214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2024
Merged

refactor: replace fabs with stdlib_base_abs in C implementation of blas/ext/base/dapxsumkbn #3214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fc2649
refactor: replace fabs with stdlib_base_abs
headlessNode Nov 21, 2024
fa0c167
Merge remote-tracking branch 'upstream/develop' into dapxsumkbn-abs-r…
stdlib-bot Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/node_modules/@stdlib/blas/ext/base/dapxsumkbn/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@
"@stdlib/napi/argv-int64",
"@stdlib/napi/argv-double",
"@stdlib/napi/argv-strided-float64array",
"@stdlib/napi/create-double"
"@stdlib/napi/create-double",
"@stdlib/math/base/special/abs"
]
},
{
Expand All @@ -58,7 +59,8 @@
"libpath": [],
"dependencies": [
"@stdlib/blas/base/shared",
"@stdlib/strided/base/stride2offset"
"@stdlib/strided/base/stride2offset",
"@stdlib/math/base/special/abs"
]
},
{
Expand All @@ -73,7 +75,8 @@
"libpath": [],
"dependencies": [
"@stdlib/blas/base/shared",
"@stdlib/strided/base/stride2offset"
"@stdlib/strided/base/stride2offset",
"@stdlib/math/base/special/abs"
]
}
]
Expand Down
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/blas/ext/base/dapxsumkbn/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
#include "stdlib/blas/ext/base/dapxsumkbn.h"
#include "stdlib/blas/base/shared.h"
#include "stdlib/strided/base/stride2offset.h"
#include <math.h>
#include "stdlib/math/base/special/abs.h"

/**
* Adds a scalar constant to each double-precision floating-point strided array element and computes the sum using an improved Kahan–Babuška algorithm.
Expand Down Expand Up @@ -72,7 +72,7 @@ double API_SUFFIX(stdlib_strided_dapxsumkbn_ndarray)( const CBLAS_INT N, const d
for ( i = 0; i < N; i++ ) {
v = alpha + X[ ix ];
t = sum + v;
if ( fabs( sum ) >= fabs( v ) ) {
if ( stdlib_base_abs( sum ) >= stdlib_base_abs( v ) ) {
c += (sum-t) + v;
} else {
c += (v-t) + sum;
Expand Down