Skip to content

Conversation

Kshitij-Dale
Copy link
Contributor

@Kshitij-Dale Kshitij-Dale commented Nov 24, 2024

Updated the main file code to add the some method
Added two benchmark files
Added a test file
Updated the readme file for explaining the usage of code

Fixes: #3155

Resolves #3155

Description

What is the purpose of this pull request?

This pull request:

  • Adds the some method to the fixed-endian-factory array. Check readme file of fixed-endian-array for understanding the usage of some method.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Updated the main file code to add the some method
Added two benchmark files
Added a test file
Updated the readme file for explaining the usage of code

Fixes: stdlib-js#3155
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 24, 2024

Coverage Report

Package Statements Branches Functions Lines
array/fixed-endian-factory $\color{red}800/1057$
$\color{green}+75.69\%$
$\color{red}54/62$
$\color{green}+87.10\%$
$\color{red}12/23$
$\color{green}+52.17\%$
$\color{red}800/1057$
$\color{green}+75.69\%$

The above coverage report was generated for the changes in this PR.

@Kshitij-Dale Kshitij-Dale reopened this Nov 24, 2024
@kgryte kgryte changed the title feat(method): added the some method to the fixed-endian array feat: add some method to array/fixed-endian-factory Nov 24, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. labels Nov 24, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @Kshitij-Dale. Left an initial round of comments.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Nov 25, 2024
@Kshitij-Dale
Copy link
Contributor Author

Thank you for the feedback @kgryte. I've implemented the requested changes. Please review the updated code.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Kshitij-Dale!

@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Nov 26, 2024
@kgryte kgryte merged commit 2df0e9b into stdlib-js:develop Nov 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Issue or pull request for adding a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add some method to array/fixed-endian-factory

3 participants