-
-
Notifications
You must be signed in to change notification settings - Fork 908
feat: add some
method to array/fixed-endian-factory
#3241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Updated the main file code to add the some method Added two benchmark files Added a test file Updated the readme file for explaining the usage of code Fixes: stdlib-js#3155
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
some
method to array/fixed-endian-factory
lib/node_modules/@stdlib/array/fixed-endian-factory/benchmark/benchmark.some.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/fixed-endian-factory/benchmark/benchmark.some.length.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/fixed-endian-factory/benchmark/benchmark.some.length.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/fixed-endian-factory/test/test.some.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/array/fixed-endian-factory/test/test.some.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, @Kshitij-Dale. Left an initial round of comments.
Thank you for the feedback @kgryte. I've implemented the requested changes. Please review the updated code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @Kshitij-Dale!
Updated the main file code to add the some method
Added two benchmark files
Added a test file
Updated the readme file for explaining the usage of code
Fixes: #3155
Resolves #3155
Description
This pull request:
Related Issues
This pull request:
some
method toarray/fixed-endian-factory
#3155Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers