Skip to content

Conversation

Vinit-Pandit
Copy link
Contributor

Resolves #3139.

Description

What is the purpose of this pull request?

This pull request:

  • add fill method to array/fixed-endian-factory

Related Issues

#3139

This pull request:

Questions

Any questions for reviewers of this pull request?

yes

  • In main.js, I am not validating whether the value parameter matches the specified data type (dtype) because I haven't found any method that validates data based on the dtype input. Additionally, the set method does not validate the input value. If validation is required, please let me know.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@Vinit-Pandit Vinit-Pandit changed the title feat: add fill method to array/fixed-endian-factory feat: add fill method to array/fixed-endian-factory Nov 27, 2024
@Vinit-Pandit
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Nov 27, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Nov 27, 2024

Coverage Report

Package Statements Branches Functions Lines
array/fixed-endian-factory $\color{red}1260/1513$
$\color{green}+83.28\%$
$\color{red}175/188$
$\color{green}+93.09\%$
$\color{red}24/34$
$\color{green}+70.59\%$
$\color{red}1260/1513$
$\color{green}+83.28\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Nov 27, 2024
@Vinit-Pandit
Copy link
Contributor Author

how much bad this coverage report is ?

Signed-off-by: Vinit Pandit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add fill method to array/fixed-endian-factory

2 participants