feat: add find method to array/fixed-endian-factory
#3286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
reviewed
Nov 27, 2024
Coverage Report
The above coverage report was generated for the changes in this PR. |
| * @throws {TypeError} `this` must be a typed array instance | ||
| * @returns {*} The value of the first element in the array that satisfies the testing function. Otherwise, undefined. | ||
| */ | ||
| setReadOnly(TypedArray.prototype, 'find', function find(predicate, thisArg) { |
There was a problem hiding this comment.
Suggested change
| setReadOnly(TypedArray.prototype, 'find', function find(predicate, thisArg) { | |
| setReadOnly( TypedArray.prototype, 'find', function find( predicate, thisArg ) { |
| setReadOnly(TypedArray.prototype, 'find', function find(predicate, thisArg) { | ||
| var value; | ||
| var i; | ||
| if (!isTypedArray(this)) { |
There was a problem hiding this comment.
Suggested change
| if (!isTypedArray(this)) { | |
| if ( !isTypedArray(this ) ) { |
Comment on lines
+588
to
+596
| throw new TypeError('invalid invocation. `this` is not a typed array instance.'); | ||
| } | ||
| if (typeof predicate !== 'function') { | ||
| throw new TypeError(format( 'invalid argument. First argument must be a function. Value: `%s`.', predicate ) ); | ||
| } | ||
| for (i = 0; i < this._length; i++) { | ||
| value = this._buffer[GETTER](i * BYTES_PER_ELEMENT, this._isLE); | ||
| if (predicate.call(thisArg, value, i, this)) { | ||
| return value; |
There was a problem hiding this comment.
Suggested change
| throw new TypeError('invalid invocation. `this` is not a typed array instance.'); | |
| } | |
| if (typeof predicate !== 'function') { | |
| throw new TypeError(format( 'invalid argument. First argument must be a function. Value: `%s`.', predicate ) ); | |
| } | |
| for (i = 0; i < this._length; i++) { | |
| value = this._buffer[GETTER](i * BYTES_PER_ELEMENT, this._isLE); | |
| if (predicate.call(thisArg, value, i, this)) { | |
| return value; | |
| throw new TypeError( 'invalid invocation. `this` is not a typed array instance.' ); | |
| } | |
| if ( typeof predicate !== 'function' ) { | |
| throw new TypeError( format( 'invalid argument. First argument must be a function. Value: `%s`.', predicate ) ); | |
| } | |
| for ( i = 0; i < this._length; i++ ) { | |
| value = this._buffer[ GETTER ]( i * BYTES_PER_ELEMENT, this._isLE ); | |
| if (predicate.call( thisArg, value, i, this ) ) { | |
| return value; |
please do same for all your changes
|
Would it be okay if I take over and complete the requested changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3141
Description
This pull request:
findmethod to thearray/fixed-endian-factoryRelated Issues
This pull request:
findmethod toarray/fixed-endian-factory#3141Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers