-
-
Notifications
You must be signed in to change notification settings - Fork 907
feat: add reverse
method to array/fixed-endian-factory
#3293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ahmad-kashkoush
wants to merge
18
commits into
stdlib-js:develop
Choose a base branch
from
ahmad-kashkoush:endian-reverse
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
08b4b49
feat: add reverse method logic
ahmad-kashkoush 853dff1
feat: add benchmark for reverse method
ahmad-kashkoush f1bb538
test: add tests for reverse method
ahmad-kashkoush 3e47bf5
docs: add documentation for reverse method
ahmad-kashkoush e7bdce9
docs: add documentation for reverse method
ahmad-kashkoush 55d746b
fix: fix reverse logic
ahmad-kashkoush 1196a89
test: fix tests for reverse method
ahmad-kashkoush 7cd3e9c
test: update test for reverse method
ahmad-kashkoush d84bfe5
Update lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
ahmad-kashkoush 58de631
Update lib/node_modules/@stdlib/array/fixed-endian-factory/README.md
ahmad-kashkoush ae68d95
Update lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
ahmad-kashkoush eab6e02
Update lib/node_modules/@stdlib/array/fixed-endian-factory/lib/main.js
ahmad-kashkoush 4ddca67
Update lib/node_modules/@stdlib/array/fixed-endian-factory/test/test.…
ahmad-kashkoush 44c7097
Update lib/node_modules/@stdlib/array/fixed-endian-factory/test/test.…
ahmad-kashkoush a8dad0e
Merge remote-tracking branch 'rem/develop' into endian-reverse
ahmad-kashkoush bf43f4c
refactor: update type checking in benchmark
ahmad-kashkoush 3687f8c
refactor: replace fcn with hasSameValues
ahmad-kashkoush def722d
Merge remote-tracking branch 'rem/develop' into endian-reverse
ahmad-kashkoush File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
lib/node_modules/@stdlib/array/fixed-endian-factory/benchmark/benchmark.reverse.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
/** | ||
* @license Apache-2.0 | ||
* | ||
* Copyright (c) 2024 The Stdlib Authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
// MODULES // | ||
|
||
var bench = require( '@stdlib/bench' ); | ||
var isTypedArray= require( '@stdlib/assert/is-typed-array' ); | ||
var factory = require( './../lib' ); | ||
var pkg = require( './../package.json' ).name; | ||
|
||
|
||
// VARIABLES // | ||
|
||
var Float64ArrayFE = factory( 'float64' ); | ||
|
||
|
||
// MAIN // | ||
|
||
bench( pkg+':reverse', function benchmark( b ) { | ||
var out; | ||
var arr; | ||
var i; | ||
|
||
arr = new Float64ArrayFE( 'little-endian', [ 1.0, 2.0, 3.0, 4.0, 5.0, 6.0, 7.0, 8.0, 9.0 ] ); | ||
|
||
b.tic(); | ||
for ( i = 0; i < b.iterations; i++ ) { | ||
out = arr.reverse( ); | ||
if ( typeof out !== 'object' ) { | ||
b.fail( 'should return an object' ); | ||
} | ||
} | ||
b.toc(); | ||
if ( !isTypedArray( out ) ) { | ||
b.fail( 'should return a typed array' ); | ||
} | ||
b.pass( 'benchmark finished' ); | ||
b.end(); | ||
}); |
100 changes: 100 additions & 0 deletions
100
lib/node_modules/@stdlib/array/fixed-endian-factory/benchmark/benchmark.reverse.length.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,100 @@ | ||
/** | ||
* @license Apache-2.0 | ||
* | ||
* Copyright (c) 2024 The Stdlib Authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
// MODULES // | ||
|
||
var bench = require( '@stdlib/bench' ); | ||
var pow = require( '@stdlib/math/base/special/pow' ); | ||
var zeroTo = require( '@stdlib/array/zero-to' ); | ||
var isTypedArray = require( '@stdlib/assert/is-typed-array' ); | ||
var factory = require( './../lib' ); | ||
var pkg = require( './../package.json' ).name; | ||
|
||
|
||
// VARIABLES // | ||
|
||
var Float64ArrayFE = factory( 'float64' ); | ||
|
||
|
||
// FUNCTIONS // | ||
|
||
/** | ||
* Creates a benchmark function. | ||
* | ||
* @private | ||
* @param {PositiveInteger} len - array length | ||
* @returns {Function} benchmark function | ||
*/ | ||
function createBenchmark( len ) { | ||
var arr = new Float64ArrayFE( 'little-endian', zeroTo( len ) ); | ||
return benchmark; | ||
|
||
/** | ||
* Benchmark function. | ||
* | ||
* @private | ||
* @param {Benchmark} b - benchmark instance | ||
*/ | ||
function benchmark( b ) { | ||
var out; | ||
var i; | ||
|
||
b.tic(); | ||
for ( i = 0; i < b.iterations; i++ ) { | ||
out = arr.reverse( ); | ||
if ( typeof out !== 'object' ) { | ||
b.fail( 'should return an object' ); | ||
} | ||
} | ||
b.toc(); | ||
if ( !isTypedArray( out ) ) { | ||
b.fail( 'should return a typed array' ); | ||
} | ||
b.pass( 'benchmark finished' ); | ||
b.end(); | ||
} | ||
} | ||
|
||
|
||
// MAIN // | ||
|
||
/** | ||
* Main execution sequence. | ||
* | ||
* @private | ||
*/ | ||
function main() { | ||
var len; | ||
var min; | ||
var max; | ||
var f; | ||
var i; | ||
|
||
min = 1; // 10^min | ||
max = 6; // 10^max | ||
|
||
for ( i = min; i <= max; i++ ) { | ||
len = pow( 10, i ); | ||
f = createBenchmark( len ); | ||
bench( pkg+':reverse:len='+len, f ); | ||
} | ||
} | ||
|
||
main(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
134 changes: 134 additions & 0 deletions
134
lib/node_modules/@stdlib/array/fixed-endian-factory/test/test.reverse.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,134 @@ | ||
/** | ||
* @license Apache-2.0 | ||
* | ||
* Copyright (c) 2024 The Stdlib Authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
// MODULES // | ||
|
||
var tape = require( 'tape' ); | ||
var hasOwnProp = require( '@stdlib/assert/has-own-property' ); | ||
var isFunction = require( '@stdlib/assert/is-function' ); | ||
var factory = require( './../lib' ); | ||
|
||
|
||
// TESTS // | ||
|
||
tape( 'main export is a function', function test( t ) { | ||
t.ok( true, __filename ); | ||
t.strictEqual( typeof factory, 'function', 'main export is a function' ); | ||
t.end(); | ||
}); | ||
|
||
tape( 'the function returns a function', function test( t ) { | ||
var ctor = factory( 'float64' ); | ||
t.strictEqual( isFunction( ctor ), true, 'returns expected value' ); | ||
t.end(); | ||
}); | ||
|
||
tape( 'attached to the prototype of the returned function is a `reverse` method', function test( t ) { | ||
var ctor = factory( 'float64' ); | ||
t.strictEqual( hasOwnProp( ctor.prototype, 'reverse' ), true, 'returns expected value' ); | ||
t.strictEqual( isFunction( ctor.prototype.reverse ), true, 'returns expected value' ); | ||
t.end(); | ||
}); | ||
|
||
tape( 'the method throws an error if invoked with a `this` context which is not a typed array instance', function test( t ) { | ||
var values; | ||
var ctor; | ||
var arr; | ||
var i; | ||
|
||
ctor = factory( 'float64' ); | ||
arr = new ctor( 'little-endian', 5 ); | ||
|
||
values = [ | ||
'5', | ||
5, | ||
NaN, | ||
true, | ||
false, | ||
null, | ||
void 0, | ||
{}, | ||
[], | ||
function noop() {} | ||
]; | ||
for ( i = 0; i < values.length; i++ ) { | ||
t.throws( badValue( values[i] ), TypeError, 'throws an error when provided '+values[i] ); | ||
} | ||
t.end(); | ||
|
||
function badValue( value ) { | ||
return function badValue() { | ||
return arr.reverse.call( value, 0 ); | ||
}; | ||
} | ||
}); | ||
|
||
tape( 'the method returns an empty array if operating on an empty typed array', function test( t ) { | ||
var ctor; | ||
var arr; | ||
var out; | ||
|
||
ctor = factory( 'float64' ); | ||
arr = new ctor('little-endian'); | ||
out = arr.reverse(); | ||
t.strictEqual( out.buffer, arr.buffer, 'returns expected value' ); | ||
t.strictEqual( out.length, 0, 'returns expected value' ); | ||
t.end(); | ||
}); | ||
|
||
tape( 'the method reverses elements of a typed array in-place', function test( t ) { | ||
var expected; | ||
var values; | ||
var ctor; | ||
var arr; | ||
var out; | ||
var i; | ||
|
||
ctor = factory( 'float64' ); | ||
arr = new ctor( 'little-endian', [ 1.0, 2.0, 3.0, 4.0, 5.0 ] ); | ||
expected = [ 5.0, 4.0, 3.0, 2.0, 1.0 ]; | ||
out = arr.reverse(); | ||
values = []; | ||
fcn(); | ||
t.strictEqual( out instanceof ctor, true, 'returns expected value' ); | ||
t.strictEqual( out, arr, 'returns expected value' ); | ||
t.strictEqual( arr.length, expected.length, 'returns expected value' ); | ||
t.deepEqual( values, expected, 'returns expected value' ); | ||
|
||
function fcn() { | ||
for ( i = 0; i < 5; i++) { | ||
values.push(arr.at(i)); | ||
ahmad-kashkoush marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
} | ||
} | ||
t.end(); | ||
}); | ||
|
||
tape( 'the method does not change the array length', function test( t ) { | ||
var ctor; | ||
var arr; | ||
var out; | ||
|
||
ctor = factory( 'float64' ); | ||
arr = new ctor( 'little-endian', [ 1.0, 2.0, 3.0, 4.0, 5.0 ] ); | ||
out = arr.reverse(); | ||
|
||
t.strictEqual( out.length, 5, 'returns expected value' ); | ||
t.end(); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.