Skip to content

refactor: use constants/float64/max-ln in math/base/special/riemann-zeta #3320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 13, 2024
Merged

refactor: use constants/float64/max-ln in math/base/special/riemann-zeta #3320

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac6c283
docs: use constants/float64/max-ln
gunjjoshi Dec 3, 2024
347dedd
docs: declare MAX_LN on top
gunjjoshi Dec 4, 2024
aae997d
refactor: inline constant value
gunjjoshi Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...es/@stdlib/math/base/special/riemann-zeta/include/stdlib/math/base/special/riemann_zeta.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ extern "C" {
/**
* Evaluates the Riemann zeta function.
*/
double stdlib_base_zeta( const double x );
double stdlib_base_zeta( const double s );

#ifdef __cplusplus
}
Expand Down
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/math/base/special/riemann-zeta/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ var TWO_PI = require( '@stdlib/constants/float64/two-pi' );
var SQRT_EPSILON = require( '@stdlib/constants/float64/sqrt-eps' );
var LN_SQRT_TWO_PI = require( '@stdlib/constants/float64/ln-sqrt-two-pi' );
var MAX_SAFE_NTH_FACTORIAL = require( '@stdlib/constants/float64/max-safe-nth-factorial' );
var FLOAT64_MAX_LN = require( '@stdlib/constants/float64/max-ln' );
var ODD_POSITIVE_INTEGERS = require( './odd_positive_integers.json' );
var EVEN_NONNEGATIVE_INTEGERS = require( './even_nonnegative_integers.json' );
var BERNOULLI = require( './bernoulli.json' );
Expand All @@ -63,7 +64,6 @@ var rateval6 = require( './rational_p6q6.js' );
// VARIABLES //

var MAX_BERNOULLI_2N = 129;
var MAX_LN = 709; // TODO: consider making external constant
var Y1 = 1.2433929443359375;
var Y3 = 0.6986598968505859375;

Expand Down Expand Up @@ -265,7 +265,7 @@ function zeta( s ) {
tmp = sinpi( 0.5*sc ) * 2.0 * zeta( s );
r = gammaln( s );
r -= s * ln( TWO_PI );
if ( r > MAX_LN ) {
if ( r > floor( FLOAT64_MAX_LN ) ) {
return ( tmp < 0.0 ) ? NINF : PINF;
}
return tmp * exp( r );
Expand Down
9 changes: 6 additions & 3 deletions lib/node_modules/@stdlib/math/base/special/riemann-zeta/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@
"@stdlib/constants/float64/two-pi",
"@stdlib/constants/float64/sqrt-eps",
"@stdlib/constants/float64/ln-sqrt-two-pi",
"@stdlib/constants/float64/max-safe-nth-factorial"
"@stdlib/constants/float64/max-safe-nth-factorial",
"@stdlib/constants/float64/max-ln"
]
},
{
Expand Down Expand Up @@ -81,7 +82,8 @@
"@stdlib/constants/float64/two-pi",
"@stdlib/constants/float64/sqrt-eps",
"@stdlib/constants/float64/ln-sqrt-two-pi",
"@stdlib/constants/float64/max-safe-nth-factorial"
"@stdlib/constants/float64/max-safe-nth-factorial",
"@stdlib/constants/float64/max-ln"
]
},
{
Expand Down Expand Up @@ -110,7 +112,8 @@
"@stdlib/constants/float64/two-pi",
"@stdlib/constants/float64/sqrt-eps",
"@stdlib/constants/float64/ln-sqrt-two-pi",
"@stdlib/constants/float64/max-safe-nth-factorial"
"@stdlib/constants/float64/max-safe-nth-factorial",
"@stdlib/constants/float64/max-ln"
]
}
]
Expand Down
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/math/base/special/riemann-zeta/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@
#include "stdlib/constants/float64/sqrt_eps.h"
#include "stdlib/constants/float64/ln_sqrt_two_pi.h"
#include "stdlib/constants/float64/max_safe_nth_factorial.h"
#include "stdlib/constants/float64/max_ln.h"
#include <stdint.h>

static const int32_t MAX_BERNOULLI_2N = 129;
static const double MAX_LN = 709.0;
static const double Y1 = 1.2433929443359375;
static const double Y3 = 0.6986598968505859375;

Expand Down Expand Up @@ -772,7 +772,7 @@ double stdlib_base_zeta( const double s ) {
tmp = stdlib_base_sinpi( 0.5 * sc ) * 2.0 * stdlib_base_zeta( scc );
r = stdlib_base_gammaln( scc );
r -= scc * stdlib_base_ln( STDLIB_CONSTANT_FLOAT64_TWO_PI );
if ( r > MAX_LN ) {
if ( r > stdlib_base_floor( STDLIB_CONSTANT_FLOAT64_MAX_LN ) ) {
return ( tmp < 0.0 ) ? STDLIB_CONSTANT_FLOAT64_NINF : STDLIB_CONSTANT_FLOAT64_PINF;
}
return tmp * stdlib_base_exp( r );
Expand Down
Loading