feat: add C implementation for `stats/base/dists/geometric/median` #4091

0PrashantYadav0 · 2024-12-20T10:54:05Z

Resolves #3636

Description

What is the purpose of this pull request?

This pull request:

adds C implementation for @stdlib/stats/base/dists/geometric/median along with relevant tests, benchmarks and examples.

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: Add C implementation for @stdlib/stats/base/dists/geometric/median #3636

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

stdlib-bot · 2024-12-20T10:56:17Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/geometric/median	$\color{green}167/167$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}167/167$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

0PrashantYadav0 · 2025-01-03T12:15:48Z

/stdlib update-copyright-years

Signed-off-by: JoyBoy <[email protected]>

0PrashantYadav0 · 2025-02-15T05:36:49Z

/stdlib merge

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

Planeshifter

Thanks for the PR!

In the implementation, we should use the respective stdlib packages instead of those from math.h.

lib/node_modules/@stdlib/stats/base/dists/geometric/median/lib/native.js

lib/node_modules/@stdlib/stats/base/dists/geometric/median/src/main.c

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

0PrashantYadav0 · 2025-03-06T06:44:03Z

@Planeshifter made all the changes please review and merge this pr.

lib/node_modules/@stdlib/stats/base/dists/geometric/median/src/main.c

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter

Lgtm.

stdlib-bot · 2025-03-07T02:55:16Z

PR Commit Message

feat: add C implementation for `stats/base/dists/geometric/median`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4091
Closes: https://github.com/stdlib-js/stdlib/issues/3636

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: JoyBoy <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

lib/node_modules/@stdlib/stats/base/dists/geometric/median/README.md

Signed-off-by: Philipp Burckhardt <[email protected]>

feat: add C implementation for geometric median

bab8e24

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 20, 2024

0PrashantYadav0 added 3 commits December 20, 2024 17:02

fix: replace name of mean to median

c15218b

fix: added constrain on p

a6c58c1

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 3, 2025

chore: update copyright years

d760f55

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 3, 2025

Planeshifter added the bot: Update Copyright Years Pull request needing the copyright years of its files updated. label Feb 9, 2025

stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: Update Copyright Years Pull request needing the copyright years of its files updated. labels Feb 9, 2025

Planeshifter removed the bot: In Progress Pull request is currently awaiting automation. label Feb 9, 2025

Merge branch 'develop' into geometric/median

c8718af

Signed-off-by: JoyBoy <[email protected]>

stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Feb 15, 2025

Planeshifter requested changes Feb 26, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dists/geometric/median/lib/native.js Show resolved Hide resolved

lib/node_modules/@stdlib/stats/base/dists/geometric/median/src/main.c Outdated Show resolved Hide resolved

Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 1, 2025

0PrashantYadav0 requested a review from Planeshifter March 6, 2025 06:43

stdlib-bot added the Needs Review A pull request which needs code review. label Mar 6, 2025

stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Mar 6, 2025

Planeshifter reviewed Mar 7, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dists/geometric/median/src/main.c Outdated Show resolved Hide resolved

chore: remove unneeded header

3105a1b

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter previously approved these changes Mar 7, 2025

View reviewed changes

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 7, 2025

stdlib-bot removed Needs Review A pull request which needs code review. Needs Changes Pull request which needs changes before being merged. labels Mar 7, 2025

Planeshifter reviewed Mar 7, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dists/geometric/median/README.md Show resolved Hide resolved

docs: add missing closing C section

55e5506

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter dismissed their stale review via 55e5506 March 7, 2025 03:08

Planeshifter approved these changes Mar 7, 2025

View reviewed changes

Planeshifter merged commit afc07e7 into stdlib-js:develop Mar 7, 2025
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: add C implementation for `stats/base/dists/geometric/median` #4091

feat: add C implementation for `stats/base/dists/geometric/median` #4091

Uh oh!

0PrashantYadav0 commented Dec 20, 2024

Uh oh!

stdlib-bot commented Dec 20, 2024 •

edited

Loading

Uh oh!

0PrashantYadav0 commented Jan 3, 2025

Uh oh!

0PrashantYadav0 commented Feb 15, 2025

Uh oh!

Planeshifter left a comment

Uh oh!

Uh oh!

Uh oh!

0PrashantYadav0 commented Mar 6, 2025

Uh oh!

Uh oh!

Planeshifter left a comment

Uh oh!

stdlib-bot commented Mar 7, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

feat: add C implementation for stats/base/dists/geometric/median #4091

feat: add C implementation for stats/base/dists/geometric/median #4091

Uh oh!

Conversation

0PrashantYadav0 commented Dec 20, 2024

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

0PrashantYadav0 commented Jan 3, 2025

Uh oh!

0PrashantYadav0 commented Feb 15, 2025

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

0PrashantYadav0 commented Mar 6, 2025

Uh oh!

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Mar 7, 2025

PR Commit Message

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: add C implementation for `stats/base/dists/geometric/median` #4091

feat: add C implementation for `stats/base/dists/geometric/median` #4091

stdlib-bot commented Dec 20, 2024 •

edited

Loading