feat: add C implementation for `@stdlib/stats/base/dists/studentized-range/cdf` #4154

jalajk3004 · 2024-12-23T05:38:35Z

Resolves #3887

Description

What is the purpose of this pull request?

This pull request:

Adds a C implementation of the studentized-range cumulative distribution function (CDF).
Includes benchmarks for the C implementation.
Provides examples demonstrating the usage of the studentized-range CDF in C.
{{TODO: add description describing what this pull request does}}

Related Issues

Does this pull request have any related issues?

This pull request:

resolves [RFC]: Add C implementation for @stdlib/stats/base/dists/studentized-range/cdf #3887

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- docs(studentized-range): add README file for C implementation Added a detailed README file for the C implementation of the studentized range distribution. This includes usage examples, function descriptions, and general guidelines for developers using the library. --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- docs(studentized-range): add README file for C implementation Added a detailed README file for the C implementation of the studentized range distribution. This includes usage examples, function descriptions, and general guidelines for developers using the library. --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: failed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: failed ---

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: failed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: failed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: failed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: failed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

stdlib-bot · 2024-12-23T05:39:07Z

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

Please read our contributing guidelines.
Update your pull request description to include this checked box:

- [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

The developer's certificate of origin
Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

stdlib-bot

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

jalajk3004 · 2024-12-23T15:05:15Z

@Planeshifter can you please review my Pull request and kindly help me to get this issue resolved.
it would a great help

anandkaranubc · 2025-01-04T04:25:38Z

Hii @jalajk3004,

I was looking over your PR and I think you accidentally tried to resolve #3384 which has perhaps been merged already.

This the right main.js for the current PR.

Good luck!

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: passed - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: failed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: passed - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: failed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: ---

jalajk3004 · 2025-01-08T13:34:24Z

@kgryte @Planeshifter I have made some changes. Please review my PR

jalajk3004 · 2025-01-10T05:24:07Z

@anandkaranubc I am positive that i resolved this issue #3887.
can you please help me to resolve this.

I really want to contribute here and want this PR to get merged.
Kindly please help me!

anandkaranubc · 2025-01-10T06:28:33Z

Also, your main.c implementation doesn't match with the main.js of stdlib/stats/base/dists/studentized-range/cdf.

Looking at the main.js, it is definitely a bit more challenging than other similar issues, because you will also need to implement gausslegdquad and prangeVInf functions in C.

You can keep this PR in draft mode for now and get an idea from other merged PRs like #3354. I did some mistakes in my first PR as well, and you can avoid those by referring to #4593. You can also look for a simpler issue than this, try implementing that and understand the standard process to be followed here. Once you are familiar, you will be able to fix your current PR as well.

Happy to help (with the limited experience I have)

Good luck!

Edit: Found this issue #3885 which is easier :)

jalajk3004 · 2025-01-13T05:18:44Z

@anandkaranubc I am grateful for your help!

kgryte and others added 4 commits December 22, 2024 12:14

stdlib-bot added the Needs Review A pull request which needs code review. label Dec 23, 2024

stdlib-bot reviewed Dec 23, 2024

View reviewed changes

jalajk3004 mentioned this pull request Dec 23, 2024

[RFC]: Add C implementation for @stdlib/stats/base/dists/studentized-range/cdf #3887

Open

3 tasks

Merge branch 'stdlib-js:develop' into feature#3887-new

aa18950

stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Jan 8, 2025

jalajk3004 and others added 2 commits January 8, 2025 13:22

Merge branch 'stdlib-js:develop' into feature#3887-new

0c0cc0b

jalajk3004 changed the title ~~feat: add C implementation for studentized range CDF~~ feat: add C implementation for @stdlib/stats/base/dists/studentized-range/cdf Jan 8, 2025

jalajk3004 mentioned this pull request Jan 13, 2025

feat: add C implementation for @stdlib/stats/base/dists/signrank/quantile #4734

Open

1 task

jalajk3004 mentioned this pull request Mar 29, 2025

[RFC]: Developer dashboard for tracking ecosystem build failures stdlib-js/google-summer-of-code#120

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: add C implementation for `@stdlib/stats/base/dists/studentized-range/cdf` #4154

feat: add C implementation for `@stdlib/stats/base/dists/studentized-range/cdf` #4154

jalajk3004 commented Dec 23, 2024

Uh oh!

stdlib-bot commented Dec 23, 2024

Uh oh!

stdlib-bot left a comment

Uh oh!

jalajk3004 commented Dec 23, 2024

Uh oh!

anandkaranubc commented Jan 4, 2025

Uh oh!

jalajk3004 commented Jan 8, 2025

Uh oh!

jalajk3004 commented Jan 10, 2025 •

edited

Loading

Uh oh!

anandkaranubc commented Jan 10, 2025 •

edited

Loading

Uh oh!

jalajk3004 commented Jan 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

feat: add C implementation for @stdlib/stats/base/dists/studentized-range/cdf #4154

Are you sure you want to change the base?

feat: add C implementation for @stdlib/stats/base/dists/studentized-range/cdf #4154

Conversation

jalajk3004 commented Dec 23, 2024

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Dec 23, 2024

Uh oh!

stdlib-bot left a comment

Choose a reason for hiding this comment

Uh oh!

jalajk3004 commented Dec 23, 2024

Uh oh!

anandkaranubc commented Jan 4, 2025

Uh oh!

jalajk3004 commented Jan 8, 2025

Uh oh!

jalajk3004 commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anandkaranubc commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jalajk3004 commented Jan 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: add C implementation for `@stdlib/stats/base/dists/studentized-range/cdf` #4154

feat: add C implementation for `@stdlib/stats/base/dists/studentized-range/cdf` #4154

jalajk3004 commented Jan 10, 2025 •

edited

Loading

anandkaranubc commented Jan 10, 2025 •

edited

Loading