Skip to content

Conversation

Neerajpathak07
Copy link
Member

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • adds C ndarray interface for stats/base/dsmean
  • refactor JavaScript implementation
  • refactor examples, tests, docs and benchmarks.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Dec 27, 2024
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 28, 2024

Coverage Report

Package Statements Branches Functions Lines
stats/base/dsmean $\color{green}346/346$
$\color{green}+100.00\%$
$\color{green}13/13$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}346/346$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review December 28, 2024 20:22
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 28, 2024
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 31, 2024
@Neerajpathak07 Neerajpathak07 marked this pull request as draft January 12, 2025 15:14
@Neerajpathak07
Copy link
Member Author

/stdlib update-copyright-years

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review January 19, 2025 06:34
@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. Needs Review A pull request which needs code review. labels Jan 19, 2025
@Neerajpathak07
Copy link
Member Author

@kgryte yes it has been merged #4331

@Neerajpathak07 Neerajpathak07 marked this pull request as draft February 3, 2025 08:29
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 3, 2025
@Neerajpathak07
Copy link
Member Author

Let me take a look at this once more and I'll get back to you

@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Feb 3, 2025
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review February 3, 2025 09:54
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 3, 2025
@Neerajpathak07
Copy link
Member Author

@kgryte
Apparently I forgot to make changes to this PR after the PR with dmeanpn got merged so apologies for the mistake!!

@Neerajpathak07 Neerajpathak07 requested a review from kgryte February 3, 2025 10:20
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is now ready to merge.

@kgryte kgryte removed Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review. labels Feb 5, 2025
@kgryte kgryte merged commit aa4e85d into stdlib-js:develop Feb 5, 2025
14 checks passed
@Neerajpathak07 Neerajpathak07 deleted the ndarray-dsmean branch February 5, 2025 11:44
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Feb 11, 2025
…s/base/dsmean`

PR-URL: stdlib-js#4300
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Co-authored-by: stdlib-bot <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
…s/base/dsmean`

PR-URL: stdlib-js#4300
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Co-authored-by: stdlib-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants