Skip to content

fix: add support for handling NewExpression in _tools/eslint/rules/line-closing-bracket-spacing #4343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 2, 2025
Merged

fix: add support for handling NewExpression in _tools/eslint/rules/line-closing-bracket-spacing #4343

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a4cb512
refactor: add support for handling NewExpression
headlessNode Dec 29, 2024
1a79f01
refactor: apply review suggestion
headlessNode Dec 29, 2024
326e645
refactor: apply review suggestion
headlessNode Dec 29, 2024
890dc6d
refactor: apply review suggestion
headlessNode Dec 29, 2024
8d8d96b
fix: apply review suggestion
headlessNode Dec 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib/node_modules/@stdlib/_tools/eslint/rules/line-closing-bracket-spacing/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ function main( context ) {
var args;

if (
node.type === 'CallExpression' &&
( node.type === 'CallExpression' || node.type === 'NewExpression' ) &&
node.arguments.length > 0
) {
args = node.arguments;
Expand All @@ -99,7 +99,10 @@ function main( context ) {
) {
report( node, prevToken, tokenAfter );
}
} else if ( lastElem.type === 'ArrayExpression' ) {
} else if (
lastElem.type === 'ArrayExpression' &&
lastElem.elements.length > 0
) {
elem = lastElem.elements[ lastElem.elements.length - 1 ];
if (
elem.type === 'ObjectExpression' &&
Expand Down Expand Up @@ -150,6 +153,7 @@ function main( context ) {
}
return {
'CallExpression': validate,
'NewExpression': validate,
'ArrayExpression': validate
};
}
Expand Down
54 changes: 45 additions & 9 deletions ...modules/@stdlib/_tools/eslint/rules/line-closing-bracket-spacing/test/fixtures/invalid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

'use strict';

var valid = [];
var invalid = [];
var test;

test = {
Expand All @@ -39,7 +39,7 @@ test = {
'}];'
].join( '\n' )
};
valid.push( test );
invalid.push( test );

test = {
'code': [
Expand Down Expand Up @@ -77,7 +77,7 @@ test = {
']);'
].join( '\n' )
};
valid.push( test );
invalid.push( test );

test = {
'code': [
Expand Down Expand Up @@ -107,7 +107,7 @@ test = {
'}]);'
].join( '\n' )
};
valid.push( test);
invalid.push( test);

test = {
'code': [
Expand Down Expand Up @@ -137,7 +137,7 @@ test = {
'}]);'
].join( '\n' )
};
valid.push( test);
invalid.push( test);

test = {
'code': [
Expand Down Expand Up @@ -170,7 +170,7 @@ test = {
'}]);'
].join( '\n' )
};
valid.push( test);
invalid.push( test);

test = {
'code': [
Expand Down Expand Up @@ -202,7 +202,7 @@ test = {
'*/'
].join( '\n' )
};
valid.push( test );
invalid.push( test );

test = {
'code': [
Expand All @@ -222,9 +222,45 @@ test = {
'});'
].join( '\n' )
};
valid.push( test );
invalid.push( test );

test = {
'code': [
' var v = new ndindex({',
' \'kind\': \'linear\'',
' } ); // some comment'
].join( '\n' ),
'errors': [{
'message': 'No spaces allowed between a closing parenthesis or bracket and a nested object or array expression at the beginning of a line',
'type': null
}],
'output': [
' var v = new ndindex({',
' \'kind\': \'linear\'',
' }); // some comment'
].join( '\n' )
};
invalid.push( test );

test = {
'code': [
' var v = new ndindex({',
' \'kind\': \'linear\'',
' } );'
].join( '\n' ),
'errors': [{
'message': 'No spaces allowed between a closing parenthesis or bracket and a nested object or array expression at the beginning of a line',
'type': null
}],
'output': [
' var v = new ndindex({',
' \'kind\': \'linear\'',
' });'
].join( '\n' )
};
invalid.push( test );


// EXPORTS //

module.exports = valid;
module.exports = invalid;
49 changes: 42 additions & 7 deletions ...les/@stdlib/_tools/eslint/rules/line-closing-bracket-spacing/test/fixtures/unvalidated.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,22 +33,22 @@ test = {
'var arrSum = sum( [ 1, 2, 3, 4 ] );'
].join( '\n' )
};
valid.push( test);
valid.push( test );

test = {
'code': [
' var log = require( \'@stdlib/console/log\' );',
' log( {} );'
].join( '\n' )
};
valid.push( test);
valid.push( test );

test = {
'code': [
'var arr = [ 1, 2, 3, 4, {} ];'
].join( '\n' )
};
valid.push( test);
valid.push( test );

test = {
'code': [
Expand All @@ -60,7 +60,7 @@ test = {
' );'
].join( '\n' )
};
valid.push( test);
valid.push( test );

test = {
'code': [
Expand All @@ -73,7 +73,7 @@ test = {
' );'
].join( '\n' )
};
valid.push( test);
valid.push( test );

test = {
'code': [
Expand All @@ -87,7 +87,7 @@ test = {
' );'
].join( '\n' )
};
valid.push( test);
valid.push( test );

test = {
'code': [
Expand All @@ -98,7 +98,42 @@ test = {
'];'
].join( '\n' )
};
valid.push( test);
valid.push( test );

test = {
'code': [
' var x = array( [] );'
].join( '\n' )
};
valid.push( test );

test = {
'code': [
' var x = array( [ {} ] );'
].join( '\n' )
};
valid.push( test );

test = {
'code': [
' var x = new Float64Array( [ 1, 2, 3, 4 ] );'
].join( '\n' )
};
valid.push( test );

test = {
'code': [
' var x = new Float64Array(',
' [',
' 1,',
' 2,',
' 3,',
' 4',
' ]',
' );'
].join( '\n' )
};
valid.push( test );


// EXPORTS //
Expand Down
18 changes: 18 additions & 0 deletions ...e_modules/@stdlib/_tools/eslint/rules/line-closing-bracket-spacing/test/fixtures/valid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,24 @@ test = {
};
valid.push( test );

test = {
'code': [
' var v = new ndindex({',
' \'kind\': \'linear\'',
' }); // some comment'
].join( '\n' )
};
valid.push( test );

test = {
'code': [
' var v = new ndindex({',
' \'kind\': \'linear\'',
' });'
].join( '\n' )
};
valid.push( test );


// EXPORTS //

Expand Down
Loading