Skip to content

feat: add C ndarray interface and refactor implementation for stats/base/svarianceyc #4372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jan 17, 2025
Merged

feat: add C ndarray interface and refactor implementation for stats/base/svarianceyc #4372

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
a12c8cd
feat: add C ndarray interface and refactor implementation for stats/b…
Vinit-Pandit Dec 30, 2024
6eba083
fix: fixing cppcheck error
Vinit-Pandit Dec 30, 2024
8e403f3
fix: fixing mistakes
Vinit-Pandit Jan 4, 2025
aec6b5a
fix: fixing comments
Vinit-Pandit Jan 4, 2025
b00ece3
fix: fixing Readme
Vinit-Pandit Jan 4, 2025
b5df583
style: remove extra space
Vinit-Pandit Jan 4, 2025
1fd8e2f
Revert previous commit
Vinit-Pandit Jan 4, 2025
199e4da
fix: readme fix
Vinit-Pandit Jan 6, 2025
925f3f7
style: fix spaces
Vinit-Pandit Jan 6, 2025
e79e0f3
Some fixes
Vinit-Pandit Jan 6, 2025
4f2726d
style: fixing space in manifest
Vinit-Pandit Jan 6, 2025
ec22b4d
fix: cleanups
Vinit-Pandit Jan 6, 2025
7515d0f
revert: spacing
Vinit-Pandit Jan 6, 2025
a5f454f
Update lib/node_modules/@stdlib/stats/base/svarianceyc/README.md
Vinit-Pandit Jan 6, 2025
3c71713
style: add trailing space in repl txt
Vinit-Pandit Jan 15, 2025
644042d
style: removing space
Vinit-Pandit Jan 15, 2025
bb02a55
Apply suggestions from code review
kgryte Jan 17, 2025
f568297
refactor: fix typo
kgryte Jan 17, 2025
8c84368
style: add empty line
kgryte Jan 17, 2025
1b00b78
style: add missing space
kgryte Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions lib/node_modules/@stdlib/stats/base/svarianceyc/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,7 @@ var options = {
* @returns {Function} benchmark function
*/
function createBenchmark( len ) {
var x;

x = uniform( len, -10, 10, options );
var x = uniform( len, -10, 10, options );
return benchmark;

function benchmark( b ) {
Expand Down
4 changes: 1 addition & 3 deletions lib/node_modules/@stdlib/stats/base/svarianceyc/benchmark/benchmark.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,7 @@ var options = {
* @returns {Function} benchmark function
*/
function createBenchmark( len ) {
var x;

x = uniform( len, -10, 10, options );
var x = uniform( len, -10, 10, options );
return benchmark;

function benchmark( b ) {
Expand Down
4 changes: 1 addition & 3 deletions lib/node_modules/@stdlib/stats/base/svarianceyc/benchmark/benchmark.ndarray.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,7 @@ var options = {
* @returns {Function} benchmark function
*/
function createBenchmark( len ) {
var x;

x = uniform( len, -10, 10, options );
var x = uniform( len, -10, 10, options );
return benchmark;

function benchmark( b ) {
Expand Down
4 changes: 1 addition & 3 deletions lib/node_modules/@stdlib/stats/base/svarianceyc/benchmark/benchmark.ndarray.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,7 @@ var options = {
* @returns {Function} benchmark function
*/
function createBenchmark( len ) {
var x;

x = uniform( len, -10, 10, options );
var x = uniform( len, -10, 10, options );
return benchmark;

function benchmark( b ) {
Expand Down
4 changes: 1 addition & 3 deletions lib/node_modules/@stdlib/stats/base/svarianceyc/examples/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@
var discreteUniform = require( '@stdlib/random/array/discrete-uniform' );
var svarianceyc = require( './../lib' );

var x;

x = discreteUniform( 10, -50, 50, {
var x = discreteUniform( 10, -50, 50, {
'dtype': 'float32'
});
console.log( x );
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/stats/base/svarianceyc/include/stdlib/stats/base/svarianceyc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ extern "C" {
float API_SUFFIX(stdlib_strided_svarianceyc)( const CBLAS_INT N, const float correction, const float *X, const CBLAS_INT strideX );

/**
* Computes the variance of a single-precision floating-point strided array using a one-pass algorithm proposed by Youngs and Cramer, using alternative indexing semantics.
* Computes the variance of a single-precision floating-point strided array using a one-pass algorithm proposed by Youngs and Cramer and alternative indexing semantics.
*/
float API_SUFFIX(stdlib_strided_svarianceyc_ndarray)( const CBLAS_INT N, const float correction, const float *X, const CBLAS_INT strideX, const CBLAS_INT offsetX );

Expand Down
8 changes: 4 additions & 4 deletions lib/node_modules/@stdlib/stats/base/svarianceyc/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ float API_SUFFIX(stdlib_strided_svarianceyc)( const CBLAS_INT N, const float cor


/**
* Computes the variance of a single-precision floating-point strided array using a one-pass algorithm proposed by Youngs and Cramer, using alternative indexing semantics.
* Computes the variance of a single-precision floating-point strided array using a one-pass algorithm proposed by Youngs and Cramer and alternative indexing semantics.
*
* @param N number of indexed elements
* @param correction degrees of freedom adjustment
Expand All @@ -65,7 +65,7 @@ float API_SUFFIX(stdlib_strided_svarianceyc_ndarray)( const CBLAS_INT N, const f

n = (double)N - (double)correction;
if ( N <= 0 || n <= 0.0f ) {
return 0.0f / 0.0f; // Nan
return 0.0f / 0.0f; // NaN
}
if ( N ==1 || strideX == 0 ) {
return 0.0f;
Expand All @@ -78,8 +78,8 @@ float API_SUFFIX(stdlib_strided_svarianceyc_ndarray)( const CBLAS_INT N, const f
di = (double)i;
v = X[ ix ];
sum += v;
d = (float)(di*(double)v) - sum;
S += (float)(1.0/(di*(di-1.0))) * d * d;
d = (float)( di * (double)v ) - sum;
S += (float)( 1.0 / ( di * ( di-1.0 ) ) ) * d * d;
ix += strideX;
}
return (double)S / n;
Expand Down
Loading