Skip to content

feat: add C ndarray interface and refactor implementation for stats/base/dmskrange #4376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kgryte merged 15 commits into from
Jan 1, 2025
Merged

feat: add C ndarray interface and refactor implementation for stats/base/dmskrange #4376

kgryte merged 15 commits into from
Jan 1, 2025

Conversation

@aayush0325
Copy link
Member

@aayush0325 aayush0325 commented Dec 30, 2024

Resolves None

Description

What is the purpose of this pull request?

This pull request:

  • adds C ndarray interface for stats/base/dmskrange
  • refactors JavaScript implementation
  • updates tests, docs, examples and benchmarks

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@aayush0325
feat: add C ndarray interface and refactor implementation
f0bce9b 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: passed
  - task: lint_c_benchmarks
    status: passed
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Dec 30, 2024
@aayush0325
Copy link
Member Author

aayush0325 commented Dec 30, 2024

same comment regarding line length exceeding in lib/ndarray.native.js, have added a TODO for that for the reviewers convenience

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 30, 2024 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dmskrange $\color{green}413/413$
$\color{green}+100.00\%$ 		$\color{green}31/31$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}413/413$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte reviewed Dec 31, 2024
View reviewed changes
kgryte
kgryte requested changes Dec 31, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the copy-paste errors in the README, may be worth taking another look at this PR before further review.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Dec 31, 2024
@aayush0325
Copy link
Member Author

aayush0325 commented Dec 31, 2024

Given the copy-paste errors in the README, may be worth taking another look at this PR before further review.

yes, taking care of this here and in other open PRs

@aayush0325
Copy link
Member Author

aayush0325 commented Dec 31, 2024

i think everything else should be okay for now here, the javascript benchmarks need to be looked at to ensure if i've taken the correct approach to avoid using manual for loops and using stdlib dependencies instead.

im getting this linting error in the tests

Linting file: lib/node_modules/@stdlib/stats/base/dmskrange/README.md
lib/node_modules/@stdlib/stats/base/dmskrange/README.md
  215:1-215:96  error  Use headings shorter than `80`  maximum-heading-length  remark-lint

how can i resolve this? @kgryte. i'll make similar changes to the other open PRs once this one gets approved

@aayush0325 aayush0325 requested a review from kgryte December 31, 2024 08:45
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 31, 2024
@aayush0325
Copy link
Member Author

aayush0325 commented Dec 31, 2024 •
edited
Loading

<!-- remark-lint-disable maximum-heading-length -->

i found this after looking around a bit, this disables the max heading lint for the whole file though. not sure if i should use this

@kgryte
Copy link
Member

kgryte commented Dec 31, 2024

@aayush0325 Yes, that is fine.

@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 31, 2024
@aayush0325
Copy link
Member Author

aayush0325 commented Dec 31, 2024

i've updated the benchmarks, although still not able to fix the linting error, need some help there @kgryte.

@aayush0325
Copy link
Member Author

aayush0325 commented Dec 31, 2024

i think by making use of random/array/bernoulli we can refactor the javascript examples too as done in previous packages, i've given it a try please go over that too @kgryte

@aayush0325
Copy link
Member Author

aayush0325 commented Dec 31, 2024

just this error left to resolve now

Linting file: lib/node_modules/@stdlib/stats/base/dmskrange/README.md
lib/node_modules/@stdlib/stats/base/dmskrange/README.md
  215:1-215:96  error  Use headings shorter than `80`  maximum-heading-length  remark-lint

@kgryte
Copy link
Member

kgryte commented Dec 31, 2024

@aayush0325 Did <!-- remark-lint-disable maximum-heading-length --> not work?

@aayush0325
Copy link
Member Author

aayush0325 commented Dec 31, 2024

@aayush0325 Did <!-- remark-lint-disable maximum-heading-length --> not work?

tried it, wasnt able to commit

@kgryte
Copy link
Member

kgryte commented Dec 31, 2024

Also, it should be <!-- lint disable maximum-heading-length -->

@aayush0325
Copy link
Member Author

aayush0325 commented Dec 31, 2024

Also, it should be <!-- lint disable maximum-heading-length -->

ah lemme try this

@aayush0325
chore: resolve lint error
fe2bd7e 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@aayush0325
Copy link
Member Author

aayush0325 commented Dec 31, 2024

works @kgryte, pushed

@aayush0325
Copy link
Member Author

aayush0325 commented Dec 31, 2024

do we need anything else @kgryte?

@aayush0325
Copy link
Member Author

aayush0325 commented Jan 1, 2025

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 1, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 1, 2025
@kgryte kgryte removed the Needs Changes Pull request which needs changes before being merged. label Jan 1, 2025
kgryte
kgryte reviewed Jan 1, 2025
View reviewed changes
@kgryte
docs: fix grammar
6184487 
Signed-off-by: Athan <[email protected]>
kgryte
kgryte reviewed Jan 1, 2025
View reviewed changes
@kgryte
docs: update note
b6303ca 
Signed-off-by: Athan <[email protected]>
kgryte
kgryte approved these changes Jan 1, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for working on this, @aayush0325!

@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Needs Review A pull request which needs code review. labels Jan 1, 2025
@kgryte kgryte merged commit eb05b7c into stdlib-js:develop Jan 1, 2025
28 checks passed
@aayush0325 aayush0325 deleted the ndarray-dmskrange branch January 2, 2025 04:42
0PrashantYadav0 pushed a commit to 0PrashantYadav0/stdlib that referenced this pull request Jan 9, 2025
@aayush0325 @kgryte
@stdlib-bot @0PrashantYadav0
feat: add C ndarray interface and refactor implementation for `stats/…
ae85b11 
…base/dmskrange`

PR-URL: stdlib-js#4376
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Co-authored-by: stdlib-bot <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@aayush0325 @kgryte
@stdlib-bot @ShabiShett07
feat: add C ndarray interface and refactor implementation for `stats/…
36ca30e 
…base/dmskrange`

PR-URL: stdlib-js#4376
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Co-authored-by: stdlib-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aayush0325 @stdlib-bot @kgryte