Skip to content

fix: wrap function calls in API_SUFFIX in native addons #4646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 8, 2025
Merged

fix: wrap function calls in API_SUFFIX in native addons #4646

merged 2 commits into from
Jan 8, 2025

Conversation

@aayush0325
Copy link
Member

Description

What is the purpose of this pull request?

This pull request:

  • wraps function calls in native addons in API_SUFFIX for all functions with ndarray interfaces

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@aayush0325
fix: wrap function calls in API_SUFFIX in native addons
034b000 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 8, 2025
@aayush0325 aayush0325 added Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Jan 8, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 8, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dmax $\color{green}369/369$
$\color{green}+100.00\%$ 		$\color{green}25/25$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}369/369$
$\color{green}+100.00\%$
stats/base/dmaxabs $\color{green}369/369$
$\color{green}+100.00\%$ 		$\color{green}23/23$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}369/369$
$\color{green}+100.00\%$
stats/base/dmaxabssorted $\color{green}314/314$
$\color{green}+100.00\%$ 		$\color{green}20/20$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}314/314$
$\color{green}+100.00\%$
stats/base/dmaxsorted $\color{green}318/318$
$\color{green}+100.00\%$ 		$\color{green}24/24$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}318/318$
$\color{green}+100.00\%$
stats/base/dmediansorted $\color{green}307/307$
$\color{green}+100.00\%$ 		$\color{green}14/14$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}307/307$
$\color{green}+100.00\%$
stats/base/dmidrange $\color{green}375/375$
$\color{green}+100.00\%$ 		$\color{green}29/29$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}375/375$
$\color{green}+100.00\%$
stats/base/dmin $\color{green}369/369$
$\color{green}+100.00\%$ 		$\color{green}25/25$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}369/369$
$\color{green}+100.00\%$
stats/base/dminabs $\color{green}369/369$
$\color{green}+100.00\%$ 		$\color{green}23/23$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}369/369$
$\color{green}+100.00\%$
stats/base/dminsorted $\color{green}318/318$
$\color{green}+100.00\%$ 		$\color{green}24/24$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}318/318$
$\color{green}+100.00\%$
stats/base/dmskmax $\color{green}412/412$
$\color{green}+100.00\%$ 		$\color{green}31/31$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}412/412$
$\color{green}+100.00\%$
stats/base/dmskmin $\color{green}411/411$
$\color{green}+100.00\%$ 		$\color{green}31/31$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}411/411$
$\color{green}+100.00\%$
stats/base/dmskrange $\color{green}413/413$
$\color{green}+100.00\%$ 		$\color{green}31/31$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}413/413$
$\color{green}+100.00\%$
stats/base/dnanmax $\color{green}380/380$
$\color{green}+100.00\%$ 		$\color{green}31/31$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}380/380$
$\color{green}+100.00\%$
stats/base/dnanmaxabs $\color{green}382/382$
$\color{green}+100.00\%$ 		$\color{green}29/29$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}382/382$
$\color{green}+100.00\%$
stats/base/dnanmeanwd $\color{green}402/402$
$\color{green}+100.00\%$ 		$\color{green}23/23$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}402/402$
$\color{green}+100.00\%$
stats/base/dnanmin $\color{green}381/381$
$\color{green}+100.00\%$ 		$\color{green}31/31$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}381/381$
$\color{green}+100.00\%$
stats/base/dnanminabs $\color{green}381/381$
$\color{green}+100.00\%$ 		$\color{green}29/29$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}381/381$
$\color{green}+100.00\%$
stats/base/dnanrange $\color{green}386/386$
$\color{green}+100.00\%$ 		$\color{green}33/33$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}386/386$
$\color{green}+100.00\%$
stats/base/drange $\color{green}375/375$
$\color{green}+100.00\%$ 		$\color{green}27/27$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}375/375$
$\color{green}+100.00\%$
stats/base/dstdevch $\color{green}350/350$
$\color{green}+100.00\%$ 		$\color{green}13/13$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}350/350$
$\color{green}+100.00\%$
stats/base/dvariancech $\color{green}396/396$
$\color{green}+100.00\%$ 		$\color{green}21/21$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}396/396$
$\color{green}+100.00\%$
stats/base/dvariancetk $\color{green}367/367$
$\color{green}+100.00\%$ 		$\color{green}21/21$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}367/367$
$\color{green}+100.00\%$
stats/base/dvariancewd $\color{green}447/447$
$\color{green}+100.00\%$ 		$\color{green}21/21$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}447/447$
$\color{green}+100.00\%$
stats/base/dvarianceyc $\color{green}385/385$
$\color{green}+100.00\%$ 		$\color{green}21/21$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}385/385$
$\color{green}+100.00\%$
stats/base/dvarmtk $\color{green}368/368$
$\color{green}+100.00\%$ 		$\color{green}21/21$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}368/368$
$\color{green}+100.00\%$
stats/base/smax $\color{green}369/369$
$\color{green}+100.00\%$ 		$\color{green}25/25$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}369/369$
$\color{green}+100.00\%$
stats/base/smaxabs $\color{green}369/369$
$\color{green}+100.00\%$ 		$\color{green}23/23$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}369/369$
$\color{green}+100.00\%$
stats/base/smaxabssorted $\color{green}314/314$
$\color{green}+100.00\%$ 		$\color{green}20/20$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}314/314$
$\color{green}+100.00\%$
stats/base/smaxsorted $\color{green}318/318$
$\color{green}+100.00\%$ 		$\color{green}24/24$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}318/318$
$\color{green}+100.00\%$
stats/base/smeanwd $\color{green}400/400$
$\color{green}+100.00\%$ 		$\color{green}20/20$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}400/400$
$\color{green}+100.00\%$
stats/base/smediansorted $\color{green}308/308$
$\color{green}+100.00\%$ 		$\color{green}14/14$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}308/308$
$\color{green}+100.00\%$
stats/base/smidrange $\color{green}375/375$
$\color{green}+100.00\%$ 		$\color{green}29/29$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}375/375$
$\color{green}+100.00\%$
stats/base/smin $\color{green}369/369$
$\color{green}+100.00\%$ 		$\color{green}25/25$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}369/369$
$\color{green}+100.00\%$
stats/base/sminabs $\color{green}369/369$
$\color{green}+100.00\%$ 		$\color{green}23/23$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}369/369$
$\color{green}+100.00\%$
stats/base/sminsorted $\color{green}318/318$
$\color{green}+100.00\%$ 		$\color{green}24/24$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}318/318$
$\color{green}+100.00\%$
stats/base/smskmax $\color{green}410/410$
$\color{green}+100.00\%$ 		$\color{green}31/31$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}410/410$
$\color{green}+100.00\%$
stats/base/smskmin $\color{green}412/412$
$\color{green}+100.00\%$ 		$\color{green}31/31$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}412/412$
$\color{green}+100.00\%$
stats/base/smskrange $\color{green}414/414$
$\color{green}+100.00\%$ 		$\color{green}31/31$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}414/414$
$\color{green}+100.00\%$
stats/base/snanmax $\color{green}380/380$
$\color{green}+100.00\%$ 		$\color{green}31/31$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}380/380$
$\color{green}+100.00\%$
stats/base/snanmaxabs $\color{green}380/380$
$\color{green}+100.00\%$ 		$\color{green}29/29$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}380/380$
$\color{green}+100.00\%$
stats/base/snanmin $\color{green}380/380$
$\color{green}+100.00\%$ 		$\color{green}31/31$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}380/380$
$\color{green}+100.00\%$
stats/base/snanminabs $\color{green}380/380$
$\color{green}+100.00\%$ 		$\color{green}29/29$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}380/380$
$\color{green}+100.00\%$
stats/base/snanrange $\color{green}387/387$
$\color{green}+100.00\%$ 		$\color{green}33/33$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}387/387$
$\color{green}+100.00\%$
stats/base/srange $\color{green}376/376$
$\color{green}+100.00\%$ 		$\color{green}27/27$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}376/376$
$\color{green}+100.00\%$
stats/base/svariancech $\color{green}401/401$
$\color{green}+100.00\%$ 		$\color{green}21/21$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}401/401$
$\color{green}+100.00\%$
stats/base/svariancetk $\color{green}372/372$
$\color{green}+100.00\%$ 		$\color{green}21/21$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}372/372$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

kgryte
kgryte approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for following up on this, @aayush0325!

@kgryte kgryte removed Needs Review A pull request which needs code review. Enhancement Issue or pull request for enhancing existing functionality. labels Jan 8, 2025
@kgryte kgryte merged commit 7e63aad into stdlib-js:develop Jan 8, 2025
57 checks passed
@aayush0325 aayush0325 deleted the API_SUFFIX_ALL branch January 8, 2025 19:40
0PrashantYadav0 pushed a commit to 0PrashantYadav0/stdlib that referenced this pull request Jan 9, 2025
@aayush0325 @0PrashantYadav0
fix: wrap function calls in API_SUFFIX in native addons
f05d522 
PR-URL: stdlib-js#4646
Reviewed-by: Athan Reines <[email protected]>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 23, 2025
@aayush0325 @Neerajpathak07
fix: wrap function calls in API_SUFFIX in native addons
f22665e 
PR-URL: stdlib-js#4646
Reviewed-by: Athan Reines <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@aayush0325 @ShabiShett07
fix: wrap function calls in API_SUFFIX in native addons
e6df9a4 
PR-URL: stdlib-js#4646
Reviewed-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte approved these changes

Assignees

No one assigned

Labels

C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aayush0325 @stdlib-bot @kgryte